Repository navigation
Conversation
izaankml
force-pushed
the
fix/report-http-status-on-non-plist
branch
from
September 14, 2026 20:45
ee97d65 to
12b361b
Compare
izaankml
added a commit
to izaankml/AltStore
that referenced
this pull request
Sep 14, 2026
Points the submodule at izaankml/AltSign classic-build: upstream notarized plus the Xcode 27 linking fix, the HTTP status reporting from rileytestut/AltSign#56, and the developer-services transport change. Build branch only; never carry this commit into a PR.
izaankml
added a commit
to izaankml/AltStore
that referenced
this pull request
Sep 14, 2026
Points the submodule at izaankml/AltSign classic-build: upstream notarized plus the Xcode 27 linking fix and the HTTP status reporting from rileytestut/AltSign#56. Build branch only; never carry this commit into a PR.
izaankml
added a commit
to izaankml/AltStore
that referenced
this pull request
Oct 18, 2026
Points the submodule at izaankml/AltSign classic-build: upstream notarized plus the Xcode 27 linking fix and the HTTP status reporting from rileytestut/AltSign#56. Build branch only; never carry this commit into a PR.
GrandSlam reports its own errors inside the plist, so the HTTP status only matters when the body is not one. Since sign-in moved to sendGSARequest it no longer checks the status, so an HTML error page (a 503, or a 429 rate limit) reaches the parser and surfaces as NSCocoaErrorDomain 3840. Parse first and, when that fails on a non-2xx response, throw ALTAppleAPIError.unknown(statusCode:).
izaankml
force-pushed
the
fix/report-http-status-on-non-plist
branch
from
October 18, 2026 06:29
12b361b to
847f195
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since 38d87aa,
sendAuthenticationRequestno longer checks the HTTP status, so an HTML error page from GrandSlam reaches the plist parser. Users see "The data couldn't be read because it isn't in the correct format" (NSCocoaErrorDomain 3840) for the 503 page Apple has returned to Android anisette since Oct 14 (altstoreio/AltStore#1834) and for HTTP 429 rate limiting.Fix
GrandSlam reports its own errors inside the plist, so the status only matters when the body is not one. Sign-in now parses first and, when that fails on a non-2xx response, throws
ALTAppleAPIError.unknown(statusCode:), the same error the 2FA requests use.Testing
Builds with the AltSign-Static scheme on macOS. An earlier revision of this change was built into AltStore Classic on iOS, and when GrandSlam rate limited sign-in the error log showed the HTTP 429 status instead of the parse error.
Related: #48, altstoreio/AltStore#1776, altstoreio/AltStore#1828