[Sets] Ignore the deprecated set objects in TwigSetProvider - #1014
Closed
TomasVotruba wants to merge 1 commit into
Closed
[Sets] Ignore the deprecated set objects in TwigSetProvider#1014TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
rectorphp/rector-src#8296 deprecates the set objects in favor of bonding rules with the ComposerPackageConstraintInterface. Twig is still resolved through a composer-triggered set, so the provider keeps using them until its rules are bonded. The entry is not reported when unmatched, so it holds both before and after the deprecation is released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares for rectorphp/rector-src#8296, which deprecates the set objects in favor of bonding rules with
ComposerPackageConstraintInterface.Twig is still resolved through a composer-triggered set, so
TwigSetProviderkeeps implementingSetProviderInterfaceand instantiatingComposerTriggeredSetuntil its rules carry their owntwig/twigconstraint. Without this, the downstream PHPStan job of rector-src fails the moment the deprecation lands:reportUnmatched: falseis what makes this mergeable in either order — the entry holds both now, where the installed rector-src has no deprecation and the pattern matches nothing, and after #8296 is released.