[Sets] Remove TwigSetProvider - #1015
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #1014: instead of ignoring the deprecated set objects in
TwigSetProvider, drop the provider itself. It was the lastSetProviderInterfaceimplementation left here, after #1010 and #1012 removed the Symfony ones.The provider only carried the Twig
composer-based.phpset, whose rules already declare their owntwig/twigconstraint - so nothing is lost by removing theComposerTriggeredSetwrapper:config/sets/twig/composer-based.phptwig112.phpRenameClassRector,twig/twig >=1.12 <1.40twig127.phpRenameMethodRector,twig/twig >=1.27twig134.phpSimpleFunctionAndFilterRector, bound totwig/twig 1.34twig140.php,twig24.php,twig-underscore-to-namespace.phpRenameClassRector,twig/twig >=1.40twig20.php>=1.40rename, as both underscore names lead to the same namespaced classtwig30.phpAddReturnTypeDeclarationRector,twig/twig >=3.0The 184 renames of
twig-underscore-to-namespace.phpwere diffed entry by entry against the>=1.40block; the only one not carried over is'Twig_Tests_EnvironmentTest_Extension' => 'Twig\Tests\EnvironmentTest\Extensio', a class from Twig's own test suite with a truncated target name.The per-version sets and the
TwigSetListconstants stay as they are, so anyone registering them by hand is unaffected.