[Sets] Remove the empty Symfony per-version set providers - #1012
Merged
Conversation
Symfony3SetProvider to Symfony8SetProvider only registered composer-triggered sets that the composer-based set already covers, rule for rule, so they were emptied in #1010. rectorphp/rector-src#8292 dropped the last reference to them, leaving six classes with an empty provide(). TwigSetProvider stays, as SetGroup::TWIG is still resolved through SetManager.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final step of the set cleanup started in #1010.
Those six providers registered 208 per-version
ComposerTriggeredSets, all of them already covered rule for rule byconfig/sets/symfony/composer-based.php, where each rule carries its own package version constraint. #1010 emptied them, keeping only the class shells because rector-src instantiated them by name. rectorphp/rector-src#8292 removed that reference, so what is left is six classes like this:All six go.
TwigSetProviderstays —SetGroup::TWIGis wired intowithComposerBased(), so its composer-based trigger is still resolved throughSetManager, and it is the only provider rector-src still instantiates from this package.The per-version set files are untouched and still reachable through the
SymfonySetList::SYMFONY_*constants.