Skip to content

[Sets] Remove the empty Symfony per-version set providers - #1012

Merged
TomasVotruba merged 1 commit into
mainfrom
remove-empty-symfony-set-providers
Aug 5, 2026
Merged

[Sets] Remove the empty Symfony per-version set providers#1012
TomasVotruba merged 1 commit into
mainfrom
remove-empty-symfony-set-providers

Conversation

@TomasVotruba

Copy link
Copy Markdown
Member

Final step of the set cleanup started in #1010.

Those six providers registered 208 per-version ComposerTriggeredSets, all of them already covered rule for rule by config/sets/symfony/composer-based.php, where each rule carries its own package version constraint. #1010 emptied them, keeping only the class shells because rector-src instantiated them by name. rectorphp/rector-src#8292 removed that reference, so what is left is six classes like this:

final class Symfony8SetProvider implements SetProviderInterface
{
    /**
     * @return SetInterface[]
     */
    public function provide(): array
    {
        return [];
    }
}

All six go. TwigSetProvider stays — SetGroup::TWIG is wired into withComposerBased(), so its composer-based trigger is still resolved through SetManager, and it is the only provider rector-src still instantiates from this package.

The per-version set files are untouched and still reachable through the SymfonySetList::SYMFONY_* constants.

Symfony3SetProvider to Symfony8SetProvider only registered composer-triggered sets that the composer-based set already covers, rule for rule, so they were emptied in #1010. rectorphp/rector-src#8292 dropped the last reference to them, leaving six classes with an empty provide().

TwigSetProvider stays, as SetGroup::TWIG is still resolved through SetManager.
@TomasVotruba
TomasVotruba merged commit 870d6d4 into main Aug 5, 2026
7 checks passed
@TomasVotruba
TomasVotruba deleted the remove-empty-symfony-set-providers branch August 5, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant