Repository navigation
fix(assistant): balance composer controls in narrow panels - #276
Merged
Merged
Conversation
Deploying document with
|
| Latest commit: |
db8f6e2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1d7b94b0.document-7hm.pages.dev |
| Branch Preview URL: | https://fix-assistant-composer-densi.document-7hm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In a narrow AI panel, Send/Stop grew to 40 px while adjacent controls stayed at 32 px. The focused composer also stacked a border and shadow, and busy 320 px panels squeezed the voice language label down to an empty chevron.
Follow-up to #274, which merged during the live-preview walkthrough. This PR contains only host CSS, browser regressions and the acceptance record; runtime and shared ChatView contracts are unchanged.
Merge Verdict
[APPROVE] — Spec, code-quality and final post-CI reviews found no outstanding blocking findings. All 19 remote checks passed on
db8f6e2e4af388b91aa09fbc4bf030c6fb692a65.Risk Analysis
Low scope: host styling only. Regression checks preserve touch targets, preparation labels, draft/IME/focus behavior, voice states and queue actions.
Design Decisions
Use the existing 32 px desktop control scale and 44 px touch target. Keep one composer boundary. Use public select CSS variables rather than modifying component internals.
Code Concerns
No outstanding findings in the reviewed increment.
Verification
Conclusion basis: Direct preview checks covered drafts/navigation, optional connector feedback, model setting separation and artifact import/edit/version save. Generation and voice regression responses are controlled fixtures, not a live-model or real-account authorization claim. The transferred source tree is identical to the locally verified tree. The deployed preview was rechecked directly: 32 px toolbar controls, 12 px inset, one 1 px focus border without shadow, no horizontal overflow in the 320 px sidebar, and the Chinese draft preserved after source navigation. All 19 latest-head CI checks passed; the final increment was reviewed again afterward. No merge was performed.