Skip to content

fix(assistant): unify workspace controls with design tokens - #277

Merged
chaxus merged 5 commits into
mainfrom
fix/assistant-workspace-consistency
Oct 16, 2026
Merged

chaxus merged 5 commits into
mainfrom
fix/assistant-workspace-consistency

Conversation

@chaxus

@chaxus chaxus commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Summary

Sources used 38px commands and 40px fields while Models used 32px controls; an undefined spacing token collapsed section gaps, and model disclosure padding expanded a nominal 32px row to 56px. This follow-up to merged #276 gives Sources, Models, Conversations and Artifacts a consistent compact layout using the existing ranui design tokens.

  • Align commands, fields, headings, spacing, hover, pressed and disabled states; retain 44px touch targets and content-sized editors.
  • Compose one flat subpage header while each view retains navigation, dirty-draft confirmation, busy disablement, localization and focus ownership.
  • Remove four undefined token roles and add token-resolution, navigation and real-component state regressions.

Merge Verdict

[APPROVE] Independent specification and quality reviews completed through ff0faee; the destructive model-command color finding was fixed and re-reviewed. Local validation, deployed-preview acceptance and all 19 latest-head CI checks passed. Final incremental review found no unresolved issues.

22 files changed, +681 / -82. Reviewed head: ff0faee348101cb7335b756118762894e746f9bc.

Risk Analysis

Risk Level Mitigation
Header navigation loses draft or operation ownership Low Reuse actual owned nodes and callbacks; test dirty/busy Back, locale updates, draft/caret restoration and historical scroll.
Compact controls clip content or hide interaction state Low Measure native and ranui frames at narrow widths, light/dark and coarse pointers; retain wrapping, keyboard focus and semantic danger colors.

Design Decisions

  • Use existing --ran-* tokens and supported ranui hooks; keep global tokens, vendor code, shared runtime/storage and standalone page CTA scale unchanged.
  • Ordinary commands remain quiet; explicit save/load/connect commitments and destructive operations retain distinct states.
  • Keep multiple focused commits as requested. The existing Google OAuth deployment remains unconfigured; this change does not claim real authorization or model-quality validation.

Code Concerns

No unresolved findings. The review caught an ordinary-button color overriding the cached-model deletion hook; the fix preserves --ran-btn-color and has a browser regression that first failed, then passed against actual ranui rendering.

Verification

Check Result
Unit tests and coverage 6,169 passed in 231 files; coverage thresholds passed
Lint and TypeScript Passed, including rebuilt workspace declarations and final TypeScript check
Formatting and production build Passed
Targeted browser workflows Final fresh build: all 39 cases passed across 11 suites (4.8 minutes)
Red/green regressions Undefined tokens, 40px source field, 56px disclosure and cached-model danger color reproduced before fixes
Independent review Specification and quality approved; no unresolved findings
Deployed preview Passed at 7357c42b: local source attach/search/highlight/remove; model-source and cloud advanced settings; draft-preserving navigation; artifact import, dirty Back/cancel and version save; 320px layout without overflow; no console errors
Latest-head CI All 19 checks passed at ff0faee: lint/unit coverage, regular E2E, timing budgets, Cloudflare Pages semantics, production Docker E2E, preview smoke, deployment and PR conventions

Conclusion basis: Local commands and browser interactions above were executed. Google OAuth and real model quality are outside this visual increment and were not tested.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying document with  Cloudflare Pages  Cloudflare Pages

Latest commit: ff0faee
Status: ✅  Deploy successful!
Preview URL: https://7357c42b.document-7hm.pages.dev
Branch Preview URL: https://fix-assistant-workspace-cons.document-7hm.pages.dev

View logs

@chaxus
chaxus merged commit f44ec64 into main Oct 16, 2026
20 checks passed
@chaxus
chaxus deleted the fix/assistant-workspace-consistency branch October 16, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant