Repository navigation
fix(assistant): unify workspace controls with design tokens - #277
Merged
Merged
Conversation
Deploying document with
|
| Latest commit: |
ff0faee
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7357c42b.document-7hm.pages.dev |
| Branch Preview URL: | https://fix-assistant-workspace-cons.document-7hm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sources used 38px commands and 40px fields while Models used 32px controls; an undefined spacing token collapsed section gaps, and model disclosure padding expanded a nominal 32px row to 56px. This follow-up to merged #276 gives Sources, Models, Conversations and Artifacts a consistent compact layout using the existing ranui design tokens.
Merge Verdict
[APPROVE] Independent specification and quality reviews completed through
ff0faee; the destructive model-command color finding was fixed and re-reviewed. Local validation, deployed-preview acceptance and all 19 latest-head CI checks passed. Final incremental review found no unresolved issues.22 files changed, +681 / -82. Reviewed head:
ff0faee348101cb7335b756118762894e746f9bc.Risk Analysis
Design Decisions
--ran-*tokens and supported ranui hooks; keep global tokens, vendor code, shared runtime/storage and standalone page CTA scale unchanged.Code Concerns
No unresolved findings. The review caught an ordinary-button color overriding the cached-model deletion hook; the fix preserves
--ran-btn-colorand has a browser regression that first failed, then passed against actual ranui rendering.Verification
ff0faee: lint/unit coverage, regular E2E, timing budgets, Cloudflare Pages semantics, production Docker E2E, preview smoke, deployment and PR conventionsConclusion basis: Local commands and browser interactions above were executed. Google OAuth and real model quality are outside this visual increment and were not tested.