Make the VU0 S1/S2 enum coverage test independent of the working directory - #233
Open
hedgeg0d wants to merge 1 commit into
Open
Make the VU0 S1/S2 enum coverage test independent of the working directory#233hedgeg0d wants to merge 1 commit into
hedgeg0d wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #101
The VU0 S1/S2 enum coverage test looked for instructions.h via paths relative to the current directory, so it only passed when ps2x_tests was run from the repo root. Running it from anywhere else failed with an empty file read.
CMake now passes the absolute path to the ps2xRecomp include dir as a compile definition, and the test tries that path first. The old relative paths stay as a fallback.