Bind the EE scheduler executor thread on first IRQ dispatch - #234
Closed
hedgeg0d wants to merge 2 commits into
Closed
Bind the EE scheduler executor thread on first IRQ dispatch#234hedgeg0d wants to merge 2 commits into
hedgeg0d wants to merge 2 commits into
Conversation
Author
|
Rebased onto upstream main so the test fix from #233 stays out of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EE scheduler requires every scheduler operation to run on the executor thread, which gets bound in reset() or bindMainContextForSyscall(). The SIF DMA path (sceSifSetDma -> dispatchDmacHandlersForCause -> dispatchIrq) never binds it, so any direct call from outside the scheduler run loop trips the executor assertion in Debug builds.
Production is unaffected because guest code always runs inside the scheduler loop, and Release builds compile the assertion out, which is why CI never caught it.
dispatchIrq now binds the executor thread on first use, mirroring the lazy binding already done in bindMainContextForSyscall(). The assertion stays in place for every subsequent call.
Verified with the Debug test suite: previously crashed in PS2SifDma after 283 tests, now all 425 tests pass.