Expand VIF UNPACK V4-5 channels - #232
Open
GTTeancum wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UNPACK V4-5RGB channels from five bits into bits 3-7 of each 32-bit laneWhy
The VIF V4-5 format does not return raw 0-31 and 0-1 channel values. Each packed channel is positioned in the high bits of its destination byte (
R5G5B5A1becomesR8G8B8A8with low bits zero). The previous implementation omitted that expansion, producing colors and alpha at 1/8 and 1/128 of their expected magnitudes.PCSX2's VIF unpack implementation uses the equivalent shifts (
X << 3,Y >> 2,Z >> 7,W >> 8).Verification
ps2x_tests: 426 passed, 0 failed