Expand VIF UNPACK V2 and V3 lanes - #237
Open
GTTeancum wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PCSX2 documents both behaviors in its VIF unpack interpreter. The V2 duplicate pair is officially indeterminate on hardware but games depend on it; V3 similarly sources W from the adjacent packed component when those bytes are present.
This is stacked on #232 because both patches touch the same UNPACK decoder. Once #232 lands, this PR should reduce to commit
34036ac.Verification
MINITEST_FILTER="VIF UNPACK V2 duplicates": 1 passed, 0 failedMINITEST_FILTER="VIF UNPACK V3 sources": 1 passed, 0 failedThe unfiltered suite still encounters pre-existing failures outside PS2Memory and terminates before this suite; the focused regression cases pass cleanly.