move check-camx-overlay.sh to libexec - #25
Closed
Agathe Porte (gagath) wants to merge 1 commit into
Closed
Conversation
This script should not be present in /usr/bin/ for such a limited use-case, and should be moved into libexec instead. Use a subdirectory named after the binary package to avoid polluting the libexec root given this script has no prefix. Signed-off-by: Agathe Porte <agathe.porte@oss.qualcomm.com>
Agathe Porte (gagath)
requested review from
NaveenCherukuri (CherukuriNaveenQC) and
GirishKadirisani
as code owners
August 11, 2026 10:37
Contributor
|
From packaging repo: qualcomm-linux/pkg-camera-service@ebbe560 |
GirishKadirisani
pushed a commit
that referenced
this pull request
Aug 17, 2026
- This script should not be present in /usr/bin/ for such a limited use-case, and should be moved into libexec instead. - Use a subdirectory named after the binary package to avoid polluting the libexec root given this script has no prefix. Ported from: #25 Signed-off-by: Agathe Porte <agathe.porte@oss.qualcomm.com> Signed-off-by: Bala Sai Kosuri <bkosuri@qti.qualcomm.com> Signed-off-by: Girish K <girik@qti.qualcomm.com>
GirishKadirisani
pushed a commit
that referenced
this pull request
Aug 17, 2026
- This script should not be present in /usr/bin/ for such a limited use-case, and should be moved into libexec instead. - Use a subdirectory named after the binary package to avoid polluting the libexec root given this script has no prefix. Ported from: #25 Signed-off-by: Agathe Porte <agathe.porte@oss.qualcomm.com> Signed-off-by: Bala Sai Kosuri <bkosuri@qti.qualcomm.com> Signed-off-by: Girish K <girik@qti.qualcomm.com>
Contributor
|
Change part of #29 |
GirishKadirisani
pushed a commit
that referenced
this pull request
Aug 20, 2026
- This script should not be present in /usr/bin/ for such a limited use-case, and should be moved into libexec instead. - Use a subdirectory named after the binary package to avoid polluting the libexec root given this script has no prefix. Ported from: #25 Signed-off-by: Agathe Porte <agathe.porte@oss.qualcomm.com> Signed-off-by: Bala Sai Kosuri <bkosuri@qti.qualcomm.com> Signed-off-by: Girish K <girik@qti.qualcomm.com>
Contributor
|
Merged as part of #29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script should not be present in /usr/bin/ for such a limited use-case, and should be moved into libexec instead.
Use a subdirectory named after the binary package to avoid polluting the libexec root given this script has no prefix.