Skip to content

Sail Mailbox changes for dt-bindings & Devicetree Overlay#649

Closed
snegi-qti wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
snegi-qti:sail_mb_changes
Closed

Sail Mailbox changes for dt-bindings & Devicetree Overlay#649
snegi-qti wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
snegi-qti:sail_mb_changes

Conversation

@snegi-qti
Copy link
Copy Markdown

Add lemans-sail-mb.dtso overlay for Lemans platform providing:

ipcc_computeL1: IPCC Compute-L1 controller
sail_mailbox: SAIL Mailbox device node

Also add IPCC_CLIENT_SAIL0/1/2/3 client ID definitions to the qcom-ipcc dt-bindings header.

CRs-Fixed: 4557036

snegi-qti added 2 commits June 3, 2026 05:22
Add IPCC_CLIENT_SAIL0/1/2/3 client ID definitions (27-30) to
the qcom-ipcc dt-bindings header for use by the SAIL Mailbox
device tree overlay.

Signed-off-by: Sankalp Negi <snegi@qti.qualcomm.com>
Add lemans-sail-mb.dtso overlay for Lemans platform providing:
  - ipcc_computeL1: IPCC Compute-L1 controller
  - sail_mailbox: SAIL Mailbox device node.

Signed-off-by: Sankalp Negi <snegi@qti.qualcomm.com>
@qlijarvis
Copy link
Copy Markdown

PR #649 — validate-patch

PR: #649

Verdict Issues Detailed Report
5 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #649 - QCLINUX: Add SAIL Mailbox support for Lemans platform
Upstream commit: N/A (vendor-only QCLINUX: patches)
Verdict: ✅ PASS

Commit 1: dt-bindings: mailbox: qcom-ipcc: Add SAIL client IDs

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only; no upstream equivalent
Body preserves rationale Clear explanation of added IDs and purpose
Fixes tag present/correct N/A New feature, not a fix
Authorship preserved Sankalp Negi correctly attributed
Backport note (if applicable) N/A Original vendor contribution

Diff

File Status Notes
include/dt-bindings/mailbox/qcom-ipcc.h Adds IPCC_CLIENT_SAIL0-3 (IDs 27-30); sequential, no conflicts

Commit 2: arm64: dts: qcom: lemans: Add SAIL Mailbox device tree overlay

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only; no upstream equivalent
Body preserves rationale Lists components added (ipcc_computeL1, sail_mailbox)
Fixes tag present/correct N/A New feature, not a fix
Authorship preserved Sankalp Negi correctly attributed
Backport note (if applicable) N/A Original vendor contribution

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile Adds lemans-sail-mb.dtbo build target; correct placement
arch/arm64/boot/dts/qcom/lemans-sail-mb.dtso New overlay; BSD-3-Clause license; uses SAIL IDs from commit 1

Issues

None identified. Both commits are well-formed vendor-only changes with:

  • Proper QCLINUX: prefix indicating vendor scope
  • Clear commit messages explaining the additions
  • Correct authorship and sign-off
  • Logical dependency ordering (header definitions before usage)
  • Consistent formatting with existing codebase patterns

Verdict

Merge as-is. Both patches are correctly structured vendor-only contributions that add SAIL Mailbox support for the Lemans platform. Commit 1 defines the required IPCC client IDs, and commit 2 adds the device tree overlay that uses them. No upstream comparison is needed or expected for QCLINUX: prefixed patches.


Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis
Copy link
Copy Markdown

PR #649 — checker-log-analyzer

PR: #649
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26884765164

Checker Result Summary
Checker Result Summary
checkpatch Both commits passed with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check Test passed
sparse-check Test passed (pre-existing errors in drm/imagination unrelated to PR)
check-uapi-headers No changes to UAPI headers
check-patch-compliance FAILED - commits missing required UPSTREAM:/FROMLIST: prefix
tag-check Subject prefix violation (QCLINUX: not allowed for qcom-6.18.y)
qcom-next-check N/A Not applicable (target branch is qcom-6.18.y, not qcom-next)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #649 - QCLINUX: dt-bindings: mailbox: qcom-ipcc: Add SAIL client IDs
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26884765164

Checker Result Summary
checkpatch Both commits passed with 0 errors, 0 warnings
dt-binding-check ⏭️ Skipped - no changes in Documentation/devicetree/bindings
dtb-check Test passed
sparse-check Test passed (pre-existing errors in drm/imagination unrelated to PR)
check-uapi-headers No changes to UAPI headers
check-patch-compliance FAILED - commits missing required UPSTREAM:/FROMLIST: prefix
tag-check Subject prefix violation (QCLINUX: not allowed for qcom-6.18.y)
qcom-next-check N/A Not applicable (target branch is qcom-6.18.y, not qcom-next)

❌ check-patch-compliance

Root cause: Both commits use QCLINUX: prefix, which is not allowed for the target branch qcom-6.18.y.

Failure details:

2026-06-03T12:45:33.1860716Z Checking commit: QCLINUX: dt-bindings: mailbox: qcom-ipcc: Add SAIL client IDs
2026-06-03T12:45:33.1875791Z Commit summary does not start with a required prefix
2026-06-03T12:45:33.1924692Z Checking commit: QCLINUX: arm64: dts: qcom: lemans: Add SAIL Mailbox device tree overlay
2026-06-03T12:45:33.1939310Z Commit summary does not start with a required prefix

Fix:

The target branch qcom-6.18.y requires commits to use either:

  • UPSTREAM: prefix if the patch has been merged into mainline Linux
  • FROMLIST: prefix if the patch has been posted to a mailing list but not yet merged

Since these appear to be Qualcomm-specific additions (SAIL client IDs and Lemans platform overlay), you have two options:

  1. If these patches exist on a mailing list: Change the prefix from QCLINUX: to FROMLIST: and include a Link: tag pointing to the lore.kernel.org URL of the patch series.

  2. If targeting qcom-next instead: Retarget this PR to the qcom-next or qcom-next-staging branch, where QCLINUX: prefix is allowed for downstream-only changes.

Example fix for option 1:

FROMLIST: dt-bindings: mailbox: qcom-ipcc: Add SAIL client IDs

Add IPCC_CLIENT_SAIL0/1/2/3 client ID definitions (27-30) to
the qcom-ipcc dt-bindings header for use by the SAIL Mailbox
device tree overlay.

Link: https://lore.kernel.org/...
Signed-off-by: Sankalp Negi <snegi@qti.qualcomm.com>

Reproduce locally:

git clone https://github.com/qualcomm-linux/kernel-checkers.git
cd kernel
bash ../kernel-checkers/check-patch-compliance.sh --kernel-src . --base <base-sha> --head <head-sha>

Verdict

1 blocker to fix: Both commits must be rebased with the correct subject prefix (UPSTREAM: or FROMLIST:) before merging to qcom-6.18.y, or the PR should be retargeted to qcom-next/qcom-next-staging if these are downstream-only changes.

@qcomlnxci
Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ❌ Fail ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️

@snegi-qti snegi-qti closed this Jun 5, 2026
@snegi-qti
Copy link
Copy Markdown
Author

Due to some compliance guidelines, we need to rename the filename and keyword. Hence closing it, I shall raise a new one with changes. Mandate came in as of yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants