Skip to content

Remove brownout risks from DPU #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
naala-qcom wants to merge 3 commits into
base: tech/mm/drm
Choose a base branch
from
+4 −6
Open

Remove brownout risks from DPU #1670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5584bd5
FROMLIST: drm/msm/dpu: Drop sneaky dev_pm_opp_set_rate(0)
quic-kdybcio Jul 28, 2026
131465b
BACKPORT: drm/msm/dp: Drop dev_pm_opp_set_rate(0)
quic-kdybcio Jul 28, 2026
c7c01de
FROMLIST: drm/msm/dsi: Drop dev_pm_opp_set_rate(0)
quic-kdybcio Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,10 @@ int dpu_core_perf_crtc_update(struct drm_crtc *crtc,

trace_dpu_core_perf_update_clk(kms->dev, !crtc->enabled, clk_rate);

/* If we're going offline, PM callbacks will disable the clocks instead */
if (!clk_rate)
return 0;

clk_rate = min(clk_rate, kms->perf.max_core_clk_rate);
ret = dev_pm_opp_set_rate(&kms->pdev->dev, clk_rate);
if (ret) {
Expand Down
4 changes: 0 additions & 4 deletions drivers/gpu/drm/msm/dp/dp_ctrl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2179,8 +2179,6 @@ static int msm_dp_ctrl_reinitialize_mainlink(struct msm_dp_ctrl_private *ctrl,
* link clock might have been adjusted as part of the
* link maintenance.
*/
dev_pm_opp_set_rate(ctrl->dev, 0);

msm_dp_ctrl_link_clk_disable(&ctrl->msm_dp_ctrl);

phy_power_off(phy);
Expand All @@ -2207,7 +2205,6 @@ static int msm_dp_ctrl_deinitialize_mainlink(struct msm_dp_ctrl_private *ctrl,

msm_dp_ctrl_reset(&ctrl->msm_dp_ctrl, panel);

dev_pm_opp_set_rate(ctrl->dev, 0);
msm_dp_ctrl_link_clk_disable(&ctrl->msm_dp_ctrl);

phy_power_off(phy);
Expand Down Expand Up @@ -2965,7 +2962,6 @@ void msm_dp_ctrl_off_link(struct msm_dp_ctrl *msm_dp_ctrl,

ctrl->mst_active = false;

dev_pm_opp_set_rate(ctrl->dev, 0);
msm_dp_ctrl_link_clk_disable(&ctrl->msm_dp_ctrl);

phy_power_off(phy);
Expand Down
2 changes: 0 additions & 2 deletions drivers/gpu/drm/msm/dsi/dsi_host.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,8 +549,6 @@ int dsi_link_clk_enable_v2(struct msm_dsi_host *msm_host)

void dsi_link_clk_disable_6g(struct msm_dsi_host *msm_host)
{
/* Drop the performance state vote */
dev_pm_opp_set_rate(&msm_host->pdev->dev, 0);
clk_disable_unprepare(msm_host->esc_clk);
clk_disable_unprepare(msm_host->pixel_clk);
clk_disable_unprepare(msm_host->byte_intf_clk);
Expand Down