Remove brownout risks from DPU - #1670
Conversation
dev_pm_opp_set_rate(0) removes the vote specified in required-opps but does not actually park the clock, making it run without the necessary power backing. Prevent that from happening when _dpu_core_perf_get_core_clk_rate() returns 0. Link: https://lore.kernel.org/all/20260728-topic-dpu_power-v1-1-e7783b859a70@oss.qualcomm.com/ Fixes: 25fdd59 ("drm/msm: Add SDM845 DPU support") Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
dev_pm_opp_set_rate(0) removes the vote specified in required-opps but does not actually park the clock, making it run without the necessary power backing. Drop the explicit calls to it. Link: https://lore.kernel.org/all/20260728-topic-dpu_power-v1-2-e7783b859a70@oss.qualcomm.com/ Fixes: c943b49 ("drm/msm/dp: add displayPort driver support") Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Signed-off-by: Nabige Aala <naala@qti.qualcomm.com>
dev_pm_opp_set_rate(0) removes the vote specified in required-opps but does not actually park the clock, making it run without the necessary power backing. Drop the explicit call to it. Every call site of ops->link_clk_disable() is followed by pm_runtime_put(), so the power vote will be rescinded if deemed safe. Link: https://lore.kernel.org/all/20260728-topic-dpu_power-v1-3-e7783b859a70@oss.qualcomm.com/ Fixes: 32d3e0f ("drm/msm: dsi: Use OPP API to set clk/perf state") Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
95b145d to
c7c01de
Compare
🔨 Build Failure Analysis — PR #1670PR: #1670 Build Status: ❌ Failed at Automerge StageFailure Type: Merge conflicts during integration (not compilation errors) Root Cause: The build workflow failed during the automerge step when attempting to integrate the PR with the
Verdict0 of 4 conflicts are introduced by this PR; all 4 are pre-existing conflicts between the baseline and the 📎 Detailed analysis: Full report |
🔨 Build Failure Analysis — PR #1670PR: #1670
VerdictNo compilation errors were introduced by this PR. The build failed during the automerge phase due to 4 pre-existing merge conflicts between the 📎 Detailed analysis: Full report |
PR #1670 — validate-patchPR: #1670
Final Summary
|
PR #1670 — checker-log-analyzerPR: #1670
Detailed report: Full report
|
Things generally run better when plugged in. That also happens to hold
for clocks. To ensure that is the case, remove calls that drop the
performance state votes while the clocks are still running.
This helps Glymur devices not crash upon resume when a display
(incl. the internal one) is plugged in.
CRs-fixed: 4616757, 4553877