Skip to content

Allow unhashable arguments when lru_cache is disabled #16626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 2 commits into from
Oct 27, 2026
Merged

Allow unhashable arguments when lru_cache is disabled #16626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9320659
Allow unhashable arguments when lru_cache is disabled
tamird Oct 27, 2026
e70bcac
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions stdlib/@tests/test_cases/check_functools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,17 @@ def check_lru_cache_with_maxsize(x: int) -> int:
assert_type(check_lru_cache_with_maxsize.cache_info().misses, int)


def check_cache_keys() -> None:
def size(*, self: list[int]) -> int:
return len(self)

disabled = lru_cache(maxsize=0)(size)
assert_type(disabled(self=[]), int)
assert_type(lru_cache(False, typed=True)(size)(self=[]), int)
cache(size)(self=[]) # type: ignore[arg-type]
lru_cache(1)(size)(self=[]) # type: ignore[arg-type]


#
# Tests for @cached_property
#
Expand Down
13 changes: 9 additions & 4 deletions stdlib/functools.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ _PWrapper = ParamSpec("_PWrapper")
_RWrapper = TypeVar("_RWrapper")
_WrapperSelfT = TypeVar("_WrapperSelfT")
_PBound = ParamSpec("_PBound")
_CacheArgT_contra = TypeVar("_CacheArgT_contra", contravariant=True, default=Hashable)

if sys.version_info >= (3, 14):
@overload
Expand All @@ -69,19 +70,23 @@ class _CacheParameters(TypedDict):
typed: bool

@final
class _lru_cache_wrapper(Generic[_T_co]):
class _lru_cache_wrapper(Generic[_T_co, _CacheArgT_contra]):
__wrapped__: Callable[..., _T_co]
def __call__(self, *args: Hashable, **kwargs: Hashable) -> _T_co: ...
def __call__(self, /, *args: _CacheArgT_contra, **kwargs: _CacheArgT_contra) -> _T_co: ...
def cache_info(self) -> _CacheInfo: ...
def cache_clear(self) -> None: ...
def cache_parameters(self) -> _CacheParameters: ...
def __copy__(self) -> _lru_cache_wrapper[_T_co]: ...
def __deepcopy__(self, memo: Any, /) -> _lru_cache_wrapper[_T_co]: ...
def __copy__(self) -> Self: ...
def __deepcopy__(self, memo: Any, /) -> Self: ...

# as with ``Callable``, we'll assume that these attributes exist
__name__: str
__qualname__: str

@overload
def lru_cache(
maxsize: Literal[0, False], typed: bool = False
) -> Callable[[Callable[..., _T]], _lru_cache_wrapper[_T, object]]: ...
@overload
def lru_cache(maxsize: int | None = 128, typed: bool = False) -> Callable[[Callable[..., _T]], _lru_cache_wrapper[_T]]: ...
@overload
Expand Down
Loading