Repository navigation
Allow unhashable arguments when lru_cache is disabled - #16626
Merged
Merged
Conversation
A zero-size cache calls the original function without constructing a key. Calling lru_cache(0)(len)([]) therefore succeeds, but the wrapper required every argument to be Hashable. Default the wrapper's argument type to Hashable and use object when maxsize is literally zero or False. Preserve that type when copying the wrapper, and make its own receiver positional-only so a wrapped function can receive a keyword named self. Unknown sizes retain the hash check.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A zero-size LRU cache calls the wrapped function without hashing its arguments, so allow
lru_cache(0)(len)([])while keeping the hash check for enabled caches and unknown sizes.Prepared with Codex.