Skip to content

Allow puppet/systemd 10.x - #1691

Open
deric wants to merge 1 commit into
puppetlabs:mainfrom
deric:systemd
Open

Allow puppet/systemd 10.x#1691
deric wants to merge 1 commit into
puppetlabs:mainfrom
deric:systemd

Conversation

@deric

@deric deric commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Allow using puppet-systemd 10.x, this might fix broken acceptance tests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the module’s Puppet Forge dependency constraints to allow puppet/systemd 10.x, aligning metadata.json with the intent to unblock environments/tests that already resolve newer puppet-systemd versions.

Changes:

  • Expand puppet/systemd dependency upper bound from < 10.0.0 to < 11.0.0 to permit 10.x releases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jst-cyr

jst-cyr commented Aug 6, 2026

Copy link
Copy Markdown
Member

@deric : Just want to thank you for this PR as I came in here to start working on this very PR to unblock some testing. I'll take a look at this today and see if we can get this merged through with engineering so tests get unblocked!

@jst-cyr

jst-cyr commented Aug 6, 2026

Copy link
Copy Markdown
Member

Running CI tests for this PR via #1692

@jst-cyr

jst-cyr commented Aug 6, 2026

Copy link
Copy Markdown
Member

Acceptance tests are mostly green: https://github.com/puppetlabs/puppetlabs-postgresql/actions/runs/31110601439/job/92662987466?pr=1692

We are seeing failures in 4 platforms:

  • Scientific 7
  • CentOS 7
  • OracleLinux 7
  • Debian 13

None of these failures seem related to the current change in this PR. They appear to be existing issues that need to be resolved in a separate PR. Scientific 7, CentOS 7, and OracleLinux 7 appear to have been failing acceptance tests for quite some time. Debian 13 acceptance testing was introduced in late May and does not appear to have ever been fully green.

For this reason, I suggest we accept this PR as matching existing acceptance testing state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants