Skip to content

support database creation from hiera parameters - #1661

Open
ikonia wants to merge 1 commit into
puppetlabs:mainfrom
ikonia:dbcreation
Open

support database creation from hiera parameters#1661
ikonia wants to merge 1 commit into
puppetlabs:mainfrom
ikonia:dbcreation

Conversation

@ikonia

@ikonia ikonia commented Feb 15, 2026

Copy link
Copy Markdown
Contributor

Summary

added $databases parameter to server.pp to allow iteration from server::database.pp to create databases
reusing the existing included pattern of $roles iterating through server::role.pp to manage roles

Additional Context

Add any additional context about the problem here.
Inability to create database using hiera parameters

Related Issues (if any)

new functionality but could also be considered a fix for #1620

Checklist

  • [ x] 🟢 Spec tests.
  • [ x] 🟢 Acceptance tests.
  • [ x] Manually verified. (For example puppet apply)

@CLAassistant

CLAassistant commented Feb 15, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Comment thread manifests/server.pp Outdated
@ikonia

ikonia commented Feb 15, 2026

Copy link
Copy Markdown
Contributor Author

tidied up git config on local machine to stop making commits with incorrect email account associated with GitHub account, merged in with correct email for CLA

@ikonia ikonia closed this Mar 24, 2026
@ikonia
ikonia deleted the dbcreation branch March 24, 2026 11:35
@ikonia
ikonia restored the dbcreation branch March 24, 2026 11:35
@ikonia

ikonia commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

closed by accident

@ikonia

ikonia commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

the other merge requests that where grouped with this change (supporting grant creation, role creation) where merged into the last release, this one was excluded, which pretty much makes the other two pointless, as if you can't create the database, there is nothing to apply grants to

@jst-cyr

jst-cyr commented Aug 5, 2026

Copy link
Copy Markdown
Member

CI test run for this PR: #1689

@jst-cyr

jst-cyr commented Aug 5, 2026

Copy link
Copy Markdown
Member

@ikonia : Thank you for the extra context... I'm going to try to help this moving forward by getting acceptance tests running against a branch PR so we can get some feedback (if necessary) or at least mark as all green before the engineering review.

@jst-cyr

jst-cyr commented Aug 6, 2026

Copy link
Copy Markdown
Member

@ikonia : It seems like testing is blocked right now because of a systemd mismatch on the metadata. There's already a PR submitted #1691 to resolve that so we can move testing forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants