Keep service-worker asset hashes stable on Windows - #92
Merged
ralyodio merged 1 commit intoSep 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With core.autocrlf=true, Windows checkouts rewrite the cached CSS/SVG assets to CRLF. The service-worker hash test then computes 4b79fdda instead of the committed bb197f9b even though no asset content was edited. This breaks the test suite and encourages platform-specific cache-version changes.
Declare LF checkout bytes for web/public CSS and SVG files using .gitattributes. This preserves the actual byte-based cache check; no asset or VERSION change is needed.
Validation: reproduced the failure on Windows, verified the upstream Git blobs produce bb197f9b, then forced a checkout of all three shell assets with core.autocrlf=true after applying these attributes. All three service-worker tests pass. git check-attr confirms text and eol=lf for each asset.
Prepared and tested by an AI coding assistant with the account owner's authorization.