Skip to content

Fix PHPStan errors in PHP 8.0-8.5 release page common.php #2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theodorejb wants to merge 2 commits into
base: master
Choose a base branch
from
+21 −132
Open

Fix PHPStan errors in PHP 8.0-8.5 release page common.php #2060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1554ef
Fix PHPStan errors in PHP 8.4 and 8.5 release page common.php
theodorejb Nov 15, 2026
f89ec75
Fix PHPStan errors in PHP 8.0-8.3 release page common.php
theodorejb Nov 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 0 additions & 114 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2082,120 +2082,6 @@ parameters:
count: 1
path: public/quickref.php

-
message: '#^Function releases\\php80\\message\(\) has parameter \$code with no type specified\.$#'
identifier: missingType.parameter
count: 1
path: public/releases/8.0/common.php

-
message: '#^Function releases\\php80\\message\(\) has parameter \$language with no type specified\.$#'
identifier: missingType.parameter
count: 1
path: public/releases/8.0/common.php

-
message: '#^Parameter \#1 \$string of function htmlspecialchars expects string, string\|false given\.$#'
identifier: argument.type
count: 1
path: public/releases/8.0/common.php

-
message: '#^Function releases\\php81\\message\(\) has parameter \$code with no type specified\.$#'
identifier: missingType.parameter
count: 1
path: public/releases/8.1/common.php

-
message: '#^Function releases\\php81\\message\(\) has parameter \$language with no type specified\.$#'
identifier: missingType.parameter
count: 1
path: public/releases/8.1/common.php

-
message: '#^Parameter \#1 \$string of function htmlspecialchars expects string, string\|false given\.$#'
identifier: argument.type
count: 1
path: public/releases/8.1/common.php

-
message: '#^Function releases\\php82\\message\(\) has parameter \$code with no type specified\.$#'
identifier: missingType.parameter
count: 1
path: public/releases/8.2/common.php

-
message: '#^Function releases\\php82\\message\(\) has parameter \$language with no type specified\.$#'
identifier: missingType.parameter
count: 1
path: public/releases/8.2/common.php

-
message: '#^Parameter \#1 \$string of function htmlspecialchars expects string, string\|false given\.$#'
identifier: argument.type
count: 1
path: public/releases/8.2/common.php

-
message: '#^Function releases\\php83\\message\(\) has parameter \$code with no type specified\.$#'
identifier: missingType.parameter
count: 1
path: public/releases/8.3/common.php

-
message: '#^Function releases\\php83\\message\(\) has parameter \$language with no type specified\.$#'
identifier: missingType.parameter
count: 1
path: public/releases/8.3/common.php

-
message: '#^Parameter \#1 \$string of function htmlspecialchars expects string, string\|false given\.$#'
identifier: argument.type
count: 1
path: public/releases/8.3/common.php

-
message: '#^Function releases\\php84\\message\(\) has parameter \$code with no type specified\.$#'
identifier: missingType.parameter
count: 1
path: public/releases/8.4/common.php

-
message: '#^Function releases\\php84\\message\(\) has parameter \$language with no type specified\.$#'
identifier: missingType.parameter
count: 1
path: public/releases/8.4/common.php

-
message: '#^Parameter \#1 \$string of function htmlspecialchars expects string, string\|false given\.$#'
identifier: argument.type
count: 1
path: public/releases/8.4/common.php

-
message: '#^Function releases\\php85\\message\(\) has parameter \$code with no type specified\.$#'
identifier: missingType.parameter
count: 1
path: public/releases/8.5/common.php

-
message: '#^Function releases\\php85\\message\(\) has parameter \$interpolations with no value type specified in iterable type array\.$#'
identifier: missingType.iterableValue
count: 1
path: public/releases/8.5/common.php

-
message: '#^Function releases\\php85\\message\(\) has parameter \$language with no type specified\.$#'
identifier: missingType.parameter
count: 1
path: public/releases/8.5/common.php

-
message: '#^Parameter \#1 \$string of function htmlspecialchars expects string, string\|false given\.$#'
identifier: argument.type
count: 1
path: public/releases/8.5/common.php

-
message: '#^Function formatDate\(\) has no return type specified\.$#'
identifier: missingType.return
Expand Down
6 changes: 3 additions & 3 deletions public/releases/8.0/common.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
function common_header(string $description): void {
global $MYSITE, $lang;

$meta_image_path = \htmlspecialchars(
\filter_var($MYSITE . 'images/php8/php_8_released.png', \FILTER_VALIDATE_URL));
$meta_image_url = \filter_var($MYSITE . 'images/php8/php_8_released.png', \FILTER_VALIDATE_URL);
$meta_image_path = $meta_image_url === false ? '' : \htmlspecialchars($meta_image_url);
$meta_description = \htmlspecialchars($description);

$languages = [];
Expand Down Expand Up @@ -56,7 +56,7 @@ function common_header(string $description): void {
]);
}

function message($code, $language = 'en'): string
function message(string $code, string $language = 'en'): string
{
$original = require __DIR__ . '/languages/en.php';
if (($language !== 'en') && file_exists(__DIR__ . '/languages/' . $language . '.php')) {
Expand Down
6 changes: 3 additions & 3 deletions public/releases/8.1/common.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
function common_header(string $description): void {
global $MYSITE, $lang;

$meta_image_path = \htmlspecialchars(
\filter_var($MYSITE . 'images/php8/php_8_1_released.png', \FILTER_VALIDATE_URL));
$meta_image_url = \filter_var($MYSITE . 'images/php8/php_8_1_released.png', \FILTER_VALIDATE_URL);
$meta_image_path = $meta_image_url === false ? '' : \htmlspecialchars($meta_image_url);
$meta_description = \htmlspecialchars($description);

$languages = [];
Expand Down Expand Up @@ -52,7 +52,7 @@ function common_header(string $description): void {
]);
}

function message($code, $language = 'en'): string
function message(string $code, string $language = 'en'): string
{
$original = require __DIR__ . '/languages/en.php';
if (($language !== 'en') && file_exists(__DIR__ . '/languages/' . $language . '.php')) {
Expand Down
6 changes: 3 additions & 3 deletions public/releases/8.2/common.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
function common_header(string $description): void {
global $MYSITE, $lang;

$meta_image_path = \htmlspecialchars(
\filter_var($MYSITE . 'images/php8/php_8_2_released.png', \FILTER_VALIDATE_URL));
$meta_image_url = \filter_var($MYSITE . 'images/php8/php_8_2_released.png', \FILTER_VALIDATE_URL);
$meta_image_path = $meta_image_url === false ? '' : \htmlspecialchars($meta_image_url);
$meta_description = \htmlspecialchars($description);

$languages = [];
Expand Down Expand Up @@ -52,7 +52,7 @@ function common_header(string $description): void {
]);
}

function message($code, $language = 'en'): string
function message(string $code, string $language = 'en'): string
{
$original = require __DIR__ . '/languages/en.php';
if (($language !== 'en') && file_exists(__DIR__ . '/languages/' . $language . '.php')) {
Expand Down
6 changes: 3 additions & 3 deletions public/releases/8.3/common.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
function common_header(string $description): void {
global $MYSITE, $lang;

$meta_image_path = \htmlspecialchars(
\filter_var($MYSITE . 'images/php8/php_8_3_released.png', \FILTER_VALIDATE_URL));
$meta_image_url = \filter_var($MYSITE . 'images/php8/php_8_3_released.png', \FILTER_VALIDATE_URL);
$meta_image_path = $meta_image_url === false ? '' : \htmlspecialchars($meta_image_url);
$meta_description = \htmlspecialchars($description);

$languages = [];
Expand Down Expand Up @@ -52,7 +52,7 @@ function common_header(string $description): void {
]);
}

function message($code, $language = 'en'): string
function message(string $code, string $language = 'en'): string
{
$original = require __DIR__ . '/languages/en.php';
if (($language !== 'en') && file_exists(__DIR__ . '/languages/' . $language . '.php')) {
Expand Down
6 changes: 3 additions & 3 deletions public/releases/8.4/common.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
function common_header(string $description): void {
global $MYSITE, $lang;

$meta_image_path = \htmlspecialchars(
\filter_var($MYSITE . 'images/php8/php_8_4_released.png', \FILTER_VALIDATE_URL));
$meta_image_url = \filter_var($MYSITE . 'images/php8/php_8_4_released.png', \FILTER_VALIDATE_URL);
$meta_image_path = $meta_image_url === false ? '' : \htmlspecialchars($meta_image_url);
$meta_description = \htmlspecialchars($description);

$languages = [];
Expand Down Expand Up @@ -54,7 +54,7 @@ function common_header(string $description): void {
]);
}

function message($code, $language = 'en'): string
function message(string $code, string $language = 'en'): string
{
$original = require __DIR__ . '/languages/en.php';
if (($language !== 'en') && file_exists(__DIR__ . '/languages/' . $language . '.php')) {
Expand Down
9 changes: 6 additions & 3 deletions public/releases/8.5/common.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
function common_header(string $description): void {
global $MYSITE, $lang;

$meta_image_path = \htmlspecialchars(
\filter_var($MYSITE . 'images/php8/php_8_5_released.png', \FILTER_VALIDATE_URL));
$meta_image_url = \filter_var($MYSITE . 'images/php8/php_8_5_released.png', \FILTER_VALIDATE_URL);
$meta_image_path = $meta_image_url === false ? '' : \htmlspecialchars($meta_image_url);
$meta_description = \htmlspecialchars($description);

$languages = [];
Expand Down Expand Up @@ -54,7 +54,10 @@ function common_header(string $description): void {
]);
}

function message($code, $language = 'en', array $interpolations = []): string
/**
* @param array<int|string, string> $interpolations
*/
function message(string $code, string $language = 'en', array $interpolations = []): string
{
$original = require __DIR__ . '/languages/en.php';
if (($language !== 'en') && file_exists(__DIR__ . '/languages/' . $language . '.php')) {
Expand Down
Loading