Repository navigation
Fix PHPStan errors in PHP 8.0-8.5 release page common.php - #2060
Open
theodorejb wants to merge 2 commits into
Open
theodorejb wants to merge 2 commits into
theodorejb wants to merge 2 commits into
Conversation
Add parameter types to message() and handle filter_var() returning false instead of passing it to htmlspecialchars(), then remove the corresponding baseline entries. I already applied this fix to the PHP 8.6 common.php on Sergey's branch.
theodorejb
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
November 15, 2026 21:36
Apply the same fixes as for 8.4 and 8.5: add parameter types to message() and handle filter_var() returning false, then remove the corresponding baseline entries.
saundefined
approved these changes
Nov 15, 2026
theodorejb
changed the title
common.phpcommon.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add parameter types to
message()and handlefilter_var()returning false instead of passing it tohtmlspecialchars(), then remove the corresponding baseline entries.I already applied this fix to the PHP 8.6
common.phpon Sergey's branch.