Repository navigation
chore(typing): remove the 14 bare type: ignore comments - #822
Merged
Merged
Conversation
Every "type: ignore" now has an error code, or is gone. - models/DH/TwoLink.py (7) and ets/ETS2.py (1, on a commented-out line): the comments never did anything. mypy only honours "type: ignore" when it is the whole comment, and these followed other comment text. Removed. - Link.I setter: convert the argument with np.asarray first, instead of ignoring that ArrayLike has no .T or .reshape. A list, or a nested list, is now accepted as the inertia; it was rejected as an invalid shape. - Link.closest_point and Link.iscollided: a link that does not belong to a robot gave "'NoneType' object has no attribute '_update_link_tf'"; it now raises ValueError saying to use skip=True. - BaseRobot's segment recursion iterates a local "link.children or []", the same as nchildren, instead of indexing an Optional list. Tests for the list inertia and the robotless link. mypy is clean and the suite is unchanged (the same 29 failures that already exist locally). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
petercorke
enabled auto-merge (squash)
October 17, 2026 02:20
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 144 144
Lines 14930 14938 +8
=====================================
- Misses 14930 14938 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The typing pass's definition of done said no
# type: ignorewithout an error code. There were 14. Now there are none without a code, and 14 fewer in total (89 to 75).models/DH/TwoLink.py(7) andets/ETS2.py(1, on a commented-out line): these never did anything. mypy only honours# type: ignorewhen it is the whole comment, and these followed other comment text. Removed.Link.Isetter: converts the argument withnp.asarrayinstead of ignoring thatArrayLikehas no.Tor.reshape. A list or nested list is now accepted as the inertia; it used to be rejected as an invalid shape.Link.closest_pointandLink.iscollided: a link not attached to a robot gave'NoneType' object has no attribute '_update_link_tf'. It now raisesValueErrorsaying to useskip=True.BaseRobotsegment recursion iterates a locallink.children or [], the same asnchildren, instead of indexing an Optional list.Two new tests (list inertia, robotless link); both fail on the old code. mypy is clean and the suite is unchanged (the same 29 failures that already exist locally, 2 more passing).
🤖 Generated with Claude Code