Repository navigation
docs(notebooks): follow the notebook plotting recipe, and fix a broken qplot call - #821
Merged
Merged
Conversation
…n qplot call
Bring RTB's notebooks in line with the RVC ecosystem notebooks.md:
- %matplotlib notebook, which does not work in JupyterLab or Notebook 7, becomes
%matplotlib ipympl, with plt.close("all") after it where pyplot is imported in
the same cell;
- the JupyterLite cell installs ipympl as well as the toolbox;
- block= arguments that the notebook backends ignore, and plt.show() calls that
only displayed a figure, are removed;
- qplot, which was a module function and is now Trajectory.qplot, is called as
the method (or xplot for fdyn results): the calls raised AttributeError.
The docs workflow installs ipympl in the JupyterLite build environment so that the
jupyter-matplotlib extension is bundled into the site; without it an ipympl figure
is blank in the browser.
Tested on the desktop only: kinematics.ipynb runs with no errors (it had one, the
qplot call). The JupyterLite side is not tested.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 144 144
Lines 14938 14938
=====================================
Misses 14938 14938 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings RTB's notebooks in line with the RVC ecosystem
notebooks.md(petercorke/rvc-ecosystem):%matplotlib notebook, which does not work in JupyterLab or Notebook 7, becomes%matplotlib ipympl(withplt.close("all")after it where pyplot is imported in the same cell).ipymplas well as the toolbox.block=arguments that the notebook backends ignore, andplt.show()calls that only displayed a figure, are removed.qplotwas a module function and is nowTrajectory.qplot. The notebooks still called the old name and raisedAttributeError; they now call the method (orxplotforfdynresults).docs.ymlinstallsipymplin the JupyterLite build environment so thejupyter-matplotlibextension is bundled into the site. Without it anipymplfigure is blank in the browser.robotics.ipynb: onlymap.plot(block=None)changes. The otherblock=Nonecalls there go to pgraph's ownplot, not RTB's, so they are untouched.Tested: on the desktop,
kinematics.ipynbnow runs with no errors (it had one, theqplotcall). Not tested: the other notebooks end to end, and the JupyterLite side (RTB installing in the browser has its own open problems). The docs workflow builds the site, which will show whether the build still works.🤖 Generated with Claude Code