Repository navigation
docs(notebooks): drop the deprecated path_marker argument - #815
Merged
Merged
Conversation
path_marker was ignored until it became a deprecated alias of path_style, and the notebook's pmarker would now change the plot. Use the default path style. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #815 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 144 144
Lines 14914 14914
=====================================
Misses 14914 14914 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`docs/notebooks/robotics.ipynb` passed `path_marker=pmarker` to `DistanceTransformPlanner.plot`. `path_marker` is now a deprecated alias of `path_style` (it used to be accepted and ignored), so the notebook would raise the deprecation warning, and `pmarker` would start changing the plot. Use the default path style and remove the unused `pmarker`.
The matching change to the book's figure scripts is petercorke/RVC3-python#59.
🤖 Generated with Claude Code