You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(dynamics): support arbitrary joint counts in paycap - #731
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer TIP This summary will be updated as you push new changes.
❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (788eaf3) to head (a30a297). ⚠️ Report is 1 commits behind head on main.
Thank you for your interest in RTB, and for fixing #728. This is merged. While reading the history I found that the original MATLAB paycap (by Bryan Moutrie) returns the minimum over joints as a scalar capacity, and the Python port dropped that min, which is where the shape problem came from. I'll follow up with that change and a hand-checkable test, and I'll credit this PR in the commit. Thanks again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #728.
The
paycap()method previously allocated a fixed six-column capacity array, causing broadcasting errors for robots with other joint counts.This PR:
(n,), or(m, n)for trajectories.The public method signature remains unchanged.
Tests
Added 8 parameterized regression cases covering:
Validation
Validated commit
90bc11einfork PR #1(huxiaoyi-ovo#1).GitHub Actions completed successfully:
Result: 19 successful jobs, 1 conditional skip, 0 failures.
The patch changes only
Dynamics.pyand its regression test file.