revert(ci): remove sticky build-matrix PR comment breaking restricted callers (2.4.1)#37
Closed
monsieurleberre wants to merge 1 commit into
Closed
revert(ci): remove sticky build-matrix PR comment breaking restricted callers (2.4.1)#37monsieurleberre wants to merge 1 commit into
monsieurleberre wants to merge 1 commit into
Conversation
… callers (2.4.1) Reverts #36 (a9b919a). The matrix-comment job requests 'actions: read', which a called workflow cannot request unless the caller's permissions block grants it — GitHub rejects the caller run at startup, on every event type, because the check is static. Every consumer repo with a restricted top-level permissions block lost CI the moment the floating v2 tag moved to 2.4.0 (daml-codegen-csharp-internal and canton-ledger-api-csharp-internal: startup_failure on all runs since 2026-07-14). The feature should return artifact-based: render the table from the existing per-shard ci-results artifacts (as matrix-output already does) instead of the jobs API, needing no extra caller permissions.
Contributor
Author
|
Decision: keep the feature; consumers grant |
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #36 and cuts 2.4.1. The
matrix-commentjob added in 2.4.0 requestsactions: read— a permission a called workflow cannot request unless the caller's top-levelpermissions:block grants it. GitHub validates this statically at run creation, so every consumer repo with a restricted permissions block getsstartup_failureon every run (push and PR alike — the job-levelif: pull_requestguard cannot help because no expression is ever evaluated).Impact observed
daml-codegen-csharp-internal: all CI runsstartup_failuresince 2026-07-14 06:37 (v2 tag moved to 2.4.0 at 07:09) — 6 merged PRs including emitter changes went unbuilt/untested, discovered while validating the 0.4.0-preview.1 release candidate.canton-ledger-api-csharp-internal: identical failure.build-and-teststayed green because it tests the helper scripts, not the reusable workflows under a restricted caller.What this PR does
matrix-commentjob fromcsharp-ci.yaml+scala-ci.yamland removesscripts/render_matrix_comment.py+ its test.[2.4.1].After merge
Tag
v2.4.1on the merge commit and move the floatingv2tag to it — consumers recover with zero caller changes on their next run (fresh runs re-resolve the tag; do not re-run old runs).Re-landing the feature
Render the table from the existing per-shard
ci-resultsartifacts (exactly howmatrix-outputaggregates today) instead ofgh api .../runs/.../jobs— no extra caller permissions needed. Alternatively, if the jobs API is required, it is a breaking change for callers (must grantactions: read) and needs a major bump + README caller-prerequisites entry.