Skip to content

fix(ci): grant permissions required by csharp-ci/scala-ci v2.4.0#29

Merged
monsieurleberre merged 1 commit into
mainfrom
fix/ci-grant-reusable-v2-permissions
Jul 17, 2026
Merged

fix(ci): grant permissions required by csharp-ci/scala-ci v2.4.0#29
monsieurleberre merged 1 commit into
mainfrom
fix/ci-grant-reusable-v2-permissions

Conversation

@monsieurleberre

Copy link
Copy Markdown
Contributor

One-line class of fix applied org-wide: the reusable workflows' new matrix-comment job (github-actions#36, shipped in 2.4.0 on the floating v2 tag) requests actions: read (+ uses pull-requests: write). A called workflow cannot request a permission its caller doesn't grant, and GitHub validates this statically at run creation — so every CI run in this repo since 2026-07-14 07:09Z ended in startup_failure before any job ran, on push and PR events alike.

This grants the missing scope(s) in the workflow-level permissions: block. Decision by the release owner: grant the read-only scope in all consumers and keep the sticky build-matrix comment feature, rather than revert it provider-side (see peacefulstudio/github-actions#37, closed).

Sibling fix verified live in daml-codegen-csharp-internal#637 (first CI run to start since the tag moved).

The reusable workflows' matrix-comment job (github-actions#36) requests actions:read and pull-requests:write; a called workflow cannot request a permission the caller does not grant, and GitHub validates this statically at run creation - every CI run since the floating v2 tag moved to 2.4.0 (2026-07-14) ended in startup_failure before any job ran.
@github-actions

Copy link
Copy Markdown
Contributor

Scala coverage

Code Coverage

Package Line Rate Branch Rate Health
studio.peaceful.daml.codegen.helper 92% 91%
Summary 92% (503 / 549) 91% (106 / 116)

@github-actions

Copy link
Copy Markdown
Contributor

C# coverage

Code Coverage

Package Line Rate Branch Rate Complexity Health
Daml.Codegen.CSharp 98% 97% 1123
Daml.Codegen.CSharp.Cli 100% 100% 3
Daml.Codegen.Testing.Conformance 82% 98% 74
Daml.Ledger.Abstractions 95% 90% 12
Daml.Runtime 95% 82% 442
Summary 96% (3839 / 3980) 93% (1454 / 1557) 1654

@github-actions

Copy link
Copy Markdown
Contributor

C# build matrix

shard result duration
macos-amd64 ✅ success 1m 15s
macos-arm64 ✅ success 51s
ubuntu-amd64 ✅ success 1m 12s
ubuntu-arm64 ✅ success 1m 05s
windows-amd64 ✅ success 1m 42s
windows-arm64 ✅ success 1m 42s

@github-actions

Copy link
Copy Markdown
Contributor

Scala build matrix

shard result duration
macos-amd64 ✅ success 2m 09s
macos-arm64 ✅ success 57s
ubuntu-amd64 ✅ success 1m 08s
ubuntu-arm64 ✅ success 1m 05s
windows-amd64 ✅ success 1m 43s

@monsieurleberre
monsieurleberre merged commit 569081b into main Jul 17, 2026
24 checks passed
@monsieurleberre
monsieurleberre deleted the fix/ci-grant-reusable-v2-permissions branch July 17, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant