feat(ui): resolve select filterOptions in the list view where builder - #17536
Open
paulpopus wants to merge 2 commits into
Open
feat(ui): resolve select filterOptions in the list view where builder#17536paulpopus wants to merge 2 commits into
paulpopus wants to merge 2 commits into
Conversation
paulpopus
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
July 29, 2026 12:00
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The list view where (filter) builder ignored a
selectfield'sfilterOptionsfunction. The filter value dropdown always showed the full staticoptionslist, even whenfilterOptionswas defined to narrow or fetch that list dynamically (e.g. from the database).Why
filterOptionswas already resolved server-side forrelationshipfields, producing aWherequery keyed by collection.selectfields usefilterOptionsdifferently: it returns a filteredOption[]instead of aWherequery. BecauseresolveAllFilterOptionsonly handled therelationshipshape,selectfiltering was not used.How
resolveAllFilterOptionsto also call aselectfield'sfilterOptionsfunction, awaiting async implementations, and store the resultingOption[]in the same resolved map used for relationship fields.resolvedFilterOptionsandfilterOptionsprop types fromResolvedFilterOptionstoOption[] | ResolvedFilterOptionsacross the list view and where builder component chain, so both shapes can flow through unchanged.WhereBuilder/Condition, use the resolvedOption[]for the filter value options when present, falling back to the field's staticoptionsotherwise.DefaultFilter, only pass the resolved value through toRelationshipFilterwhen it is aWherequery, avoiding anOption[]being mistaken for relationship filter options.