fix: catch errors from filter options in list view WhereBuilder - #17552
Open
paulpopus wants to merge 6 commits into
Open
fix: catch errors from filter options in list view WhereBuilder#17552paulpopus wants to merge 6 commits into
paulpopus wants to merge 6 commits into
Conversation
paulpopus
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
July 29, 2026 21:20
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A
filterOptionsfunction is user-authored code and can throw. Before this change, a throwingfilterOptionscrashed the list view, crashed the edit and create views, and could crash a document create or update with an unhandled error. This change catches those errors at every call site and applies a consistent, safe fallback.How
filterOptionsfor display (list view filter panel, edit/create view form state) now catches a thrown error, logs it, and falls back to the field's unfiltered options. This covers relationship, upload, select, and blocks fields.filterOptionsfor validation (document create and update) now catches a thrown error, logs it, and fails validation for that field. A brokenfilterOptionsblocks the write instead of silently accepting an unverified value.filterOptions. Select and blocks field validation did not; both now match. A second, unguardedfilterOptionsre-check used to build a per-block error message is also covered.Alternatives considered
For validation, a throwing
filterOptionscould instead fall back to unfiltered, matching the display behavior. This was rejected becausefilterOptionscan act as an access restriction on writes, and silently lifting that restriction on error would allow an unverified value through instead of surfacing the misconfiguration.First merge this: #17536