[fix] check Play reachability before building, not after publishing - #277
Merged
Conversation
The guard added in the previous commit sat between "Create the GitHub release" and the upload, which is the one place it is nearly useless: by the time it fires, five minutes of build have been spent and a GitHub release for the tag already exists, so the failure leaves exactly the half-made state the guard was added to prevent — just red instead of green. A precondition belongs before the work. It now runs straight after checkout, costs seconds, and leaves nothing to clean up.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Moves the
PLAY_SERVICE_ACCOUNT_JSONprecondition from just-before-the-upload to just-after-checkout.Why
Follow-up to #276, fixing a placement mistake in it. The guard sat between Create the GitHub release and Upload to the Play internal track — the one position where it barely helps. By the time it fires:
.aabis built and signedwhich is precisely the half-made state the guard exists to prevent. It just makes it red instead of green. A precondition belongs before the work it protects: it now runs immediately after checkout, fails in seconds, and leaves nothing behind to clean up or re-tag around.
No behaviour change otherwise — same condition, same message, same
skip_play_uploadopt-out.How it was verified
bunx tsc --noEmit/bunx vitest runpass