[docs] drop the comment describing the skip that no longer happens - #278
Merged
Conversation
The banner above the Play upload step still said the upload skips itself silently until identity verification clears. Verification cleared 2026-08-17 and the skip became a hard precondition two commits ago, so the comment described the opposite of the code — which is worse than no comment, since it is exactly what someone debugging a failed release would read first.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #276/#277. The banner comment above the Play upload step survived those edits and still described the old behaviour — "skipped, silently and successfully, until
PLAY_SERVICE_ACCOUNT_JSONexists… it cannot exist yet". Verification cleared on 2026-08-17 and the skip is now a hard precondition at the top of the job, so the comment said the opposite of the code, in the place someone debugging a failed release reads first.Comment only; workflow parses as YAML and no step changed.