Skip to content

remove expired session if refresh token missing #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikhilsinhaparseable merged 2 commits into from
Oct 28, 2026
Merged

remove expired session if refresh token missing #1835

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73c80a8
remove expired session if refresh token missing
nikhilsinhaparseable Oct 28, 2026
40bbf9e
update message on missing refresh token
nikhilsinhaparseable Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/handlers/http/middleware.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,18 @@ pub async fn refresh_token(
};

if let Some(oauth_data) = bearer_to_refresh {
if !oauth_data
.bearer
.as_ref()
.and_then(|bearer| bearer.refresh_token.as_deref())
.is_some_and(|token| !token.is_empty())
{
Users.remove_session(key);
return Err(ErrorUnauthorized(
"Your OIDC session cannot be refreshed because the identity provider did not issue a refresh token. Please sign in again and ask your administrator to configure the offline_access scope.",
));
}

let refreshed_token = match client
.read()
.await
Expand Down
Loading