You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Select direct ClusterObjectSet scenarios with @ObjectController and @ClusterObjectSet, and use object-controller readiness without requiring
operator-controller or catalogd.
Keep the revision-pruning integration scenario behind @BoxcutterRuntime and
move its OLM and registry prerequisites into that scenario. This allows direct
COS coverage to run against a standalone object-controller installation while
preserving ClusterExtension integration coverage.
This is the second PR in the OPRUN-4849 stack, following merged PR #3158.
Later branches enable standalone COD scenarios and add COS lifecycle coverage.
COS branch: 56 E2E helper tests passed with the race detector.
All E2E suites compile, and object-controller step registration succeeds.
Rebased combined stack: make verify, make lint (0 issues), and make test-unit passed using Go 1.26.5.
Standalone COS live run: 31 scenarios / 216 steps passed, with no skipped or
undefined steps, against object-controller without operator-controller or
catalogd.
The complete branch diff against main contains 6 files.
Reviewer Checklist
API Go Documentation
Tests: Unit Tests (and E2E Tests, if appropriate)
Comprehensive Commit Messages
Links to related GitHub Issue(s)
Summary by CodeRabbit
Tests
Updated end-to-end scenarios to check object-controller availability and use more specific test tags.
Adjusted setup for selected scenarios to include the services they require.
Collision, adoption, preflight, validation, and revision scenarios remain covered.
Select direct COS scenarios with ObjectController and ClusterObjectSet
tags and require only object-controller in their shared prerequisites.
Keep ClusterExtension integration coverage behind BoxcutterRuntime.
Move registry setup into the group pruning integration scenario so direct
COS scenarios can run without catalogd or operator-controller.
Refs: OPRUN-4849
Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com>
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
No actionable comments were generated in the recent review.
Walkthrough
End-to-end feature tags and setup steps now distinguish ObjectController scenarios from the revision-pruning scenario, which retains OLM and image-registry setup.
Changes: ObjectController end-to-end tests
Layer / File(s)
Summary
Update feature tags and prerequisites test/e2e/object-controller/features/cos_object_collision_and_adoption.feature, test/e2e/object-controller/features/cos_preflight.feature, test/e2e/object-controller/features/cos_revision_identity.feature, test/e2e/object-controller/features/cos_static_validation.feature, test/e2e/object-controller/features/revision.feature
These features use ObjectController tags. Background setup checks for object-controller availability where changed.
Scope setup to group scenarios test/e2e/object-controller/features/group.feature
The feature-level Boxcutter tag is removed. ObjectController tags are added to selected scenarios, and OLM and image-registry setup moves to revision pruning.
This PR changes only E2E test tags and setup steps so that direct ClusterObjectSet scenarios can run against object-controller alone. No production code changes, and no concrete merge-blocking risk remains.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title "🌱 OPRUN-4849: Enable standalone ClusterObjectSet E2E scenarios" matches the main change. The diff retags the direct ClusterObjectSet feature files from BoxcutterRuntime to ObjectController …
Description check
The description follows the repository template. It has a Description section that explains the change and its motivation: direct COS scenarios run against standalone object-controller, and the revisi…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "🌱 OPRUN-4849: Enable standalone ClusterObjectSet E2E scenarios" matches the main change. The diff retags the direct ClusterObjectSet feature files from BoxcutterRuntime to ObjectController and ClusterObjectSet, and switches their background readiness from OLM to object-controller. The title uses the correct seedling prefix for an 'other' change and names the Jira key.
Full details: Description check
Explanation
The description follows the repository template. It has a Description section that explains the change and its motivation: direct COS scenarios run against standalone object-controller, and the revision-pruning scenario stays behind BoxcutterRuntime with its OLM and registry prerequisites moved into it. It also lists validation steps and the Jira link. The Reviewer Checklist is present with items checked. The API Go Documentation item is unchecked, which fits a change that alters no exported declarations.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Enterprise
Run ID: 86e06c2d-7ac6-4dc4-a090-e7e6ed79ae67
Commits
Reviewing files that changed from the base of the PR and between 2534523 and cf29926.
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Select direct ClusterObjectSet scenarios with
@ObjectControllerand@ClusterObjectSet, and use object-controller readiness without requiringoperator-controller or catalogd.
Keep the revision-pruning integration scenario behind
@BoxcutterRuntimeandmove its OLM and registry prerequisites into that scenario. This allows direct
COS coverage to run against a standalone object-controller installation while
preserving ClusterExtension integration coverage.
This is the second PR in the OPRUN-4849 stack, following merged PR #3158.
Later branches enable standalone COD scenarios and add COS lifecycle coverage.
Jira: https://redhat.atlassian.net/browse/OPRUN-4849
Validation:
make verify,make lint(0 issues), andmake test-unitpassed using Go 1.26.5.undefined steps, against object-controller without operator-controller or
catalogd.
maincontains 6 files.Reviewer Checklist
Summary by CodeRabbit