Skip to content

🌱 OPRUN-4849: Enable standalone ClusterObjectDeployment E2E scenarios - #3162

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
fao89:OPRUN-4849-cod
Nov 12, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
fao89:OPRUN-4849-cod

Conversation

@fao89

@fao89 fao89 commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Description

Select direct ClusterObjectDeployment scenarios with @ObjectController and
@ClusterObjectDeployment, and use object-controller readiness without
requiring operator-controller or catalogd.

This builds on the runtime support merged in #3158. It is independent of the
ClusterObjectSet scenarios in #3161: either PR can merge first, and the branches
change separate feature files. Shared COS/COD usage documentation and lifecycle
coverage will follow in a later PR.

Jira: https://redhat.atlassian.net/browse/OPRUN-4849

Validation:

  • Independent COD branch: 56 E2E helper tests passed with the race detector
    using Go 1.26.5.
  • All E2E suites compile, and object-controller step registration succeeds.
  • Both COS/COD merge orders are conflict-free and produce the same tree.
  • The complete branch diff against main contains 6 files.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Summary by CodeRabbit

  • Tests
    • Updated end-to-end coverage to verify deployment handoff, lifecycle, rollout behavior, revision history, template metadata, and progress reporting against the object controller.
    • Test setup now checks that the object controller is available before running these scenarios.

Select direct COD scenarios independently of BoxcutterRuntime and use
object-controller readiness without ClusterExtension dependencies.

Refs: OPRUN-4849
Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@netlify

netlify Bot commented Nov 12, 2026

Copy link
Copy Markdown

👷 Deploy request for olmv1 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 107a04c

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Six COD end-to-end feature files now use ObjectController-related tags and check for object-controller availability instead of OLM.

Changes: COD end-to-end feature setup

Layer / File(s) Summary
Feature tags and readiness checks
test/e2e/object-controller/features/cod_handoff.feature, test/e2e/object-controller/features/cod_lifecycle.feature, test/e2e/object-controller/features/cod_progressing_reasons.feature, test/e2e/object-controller/features/cod_revision_history.feature, test/e2e/object-controller/features/cod_rollout.feature, test/e2e/object-controller/features/cod_template_metadata.feature
The feature tags replace @BoxcutterRuntime with @ObjectController; five files also add @ClusterObjectDeployment. Each background now checks that object-controller is available instead of checking OLM.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

Suggested reviewers: perdasilva

Merge Risk: Minimal · up to 107a0

This change moves the COD end-to-end scenarios to object-controller tags and readiness checks. No concrete merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: enabling standalone ClusterObjectDeployment E2E scenarios. The raw summary shows the feature files retagged from BoxcutterRuntime to ObjectController and ClusterObject…
Description check Passed The description follows the template's main parts. It has a Description section that explains the change and its motivation, and it links the related PRs and the Jira issue. The Reviewer Checklist is …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: enabling standalone ClusterObjectDeployment E2E scenarios. The raw summary shows the feature files retagged from BoxcutterRuntime to ObjectController and ClusterObjectDeployment, with object-controller readiness replacing OLM in the background steps. The title uses the 🌱 prefix that the template requires for other changes, and it includes the Jira key.

Full details: Description check

Explanation

The description follows the template's main parts. It has a Description section that explains the change and its motivation, and it links the related PRs and the Jira issue. The Reviewer Checklist is present, with unit tests, commit messages, and issue links checked. The API Go Documentation item is left unchecked, which fits a change with no exported API alterations. The template's title icon rule is not restated in the body, but the title carries the 🌱 prefix.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 9f6a4e4f-e6da-4507-8ce5-d066c30b63f4
Commits

Reviewing files that changed from the base of the PR and between 2534523 and 107a04c.

Files selected for processing: 6

  • test/e2e/object-controller/features/cod_handoff.feature
  • test/e2e/object-controller/features/cod_lifecycle.feature
  • test/e2e/object-controller/features/cod_progressing_reasons.feature
  • test/e2e/object-controller/features/cod_revision_history.feature
  • test/e2e/object-controller/features/cod_rollout.feature
  • test/e2e/object-controller/features/cod_template_metadata.feature

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

@perdasilva

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Nov 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2026

@fgiudici fgiudici left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 5f87083 into operator-framework:main Nov 12, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants