Repository navigation
This commit allows mito genes (currently ensembl only) to validate as tx - #883
Open
Peter-J-Freeman wants to merge 2 commits into
Open
Peter-J-Freeman wants to merge 2 commits into
Peter-J-Freeman wants to merge 2 commits into
Conversation
The relevant transcript mappings have been fixed and the code updated top allow mito genes to produce c. and m. from genomic m.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## regex_removal #883 +/- ##
=================================================
+ Coverage 84.91% 84.97% +0.06%
=================================================
Files 48 48
Lines 14589 14614 +25
=================================================
+ Hits 12388 12418 +30
+ Misses 2201 2196 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The mito translation table is non-standard. The code pushed has tests based on the accidentally malformed VVTA before we spotted it, so it has broken tests.
Collaborator
Author
|
Note on merge. This branch has code we need, but the tests are, I have just discovered, based on the broken VVTA database. It may be best not to merge this, but to work in the code changes or tests may get overwritten. Tests can be based on import json
import VariantValidator
vval = VariantValidator.Validator()
variant = "NC_012920.1(MT-ND4):m.11232T>C"
genome_build = 'GRCh38'
select_transcripts = 'all'
transcript_set = 'ensembl'
validate = vval.validate(variant, genome_build, select_transcripts, transcript_set)
validation = validate.format_as_dict(with_meta=True)
print(json.dumps(validation, sort_keys=True, indent=4, separators=(',', ': '))){
"ENST00000361381.2:c.473T>C": {
"alt_genomic_loci": [],
"annotations": {
"chromosome": "MT",
"db_xref": {
"CCDS": null,
"ensemblgene": "ENSG00000198886",
"hgnc": "HGNC:7459",
"ncbigene": null,
"select": "Ensembl"
},
"ensembl_select": true,
"mane_plus_clinical": false,
"mane_select": false,
"map": "mitochondria",
"note": "mitochondrially encoded NADH:ubiquinone oxidoreductase core subunit 4",
"refseq_select": false,
"variant": "201"
},
"gene_ids": {
"ccds_ids": [],
"ensembl_gene_id": "ENSG00000198886",
"entrez_gene_id": "4538",
"hgnc_id": "HGNC:7459",
"omim_id": [
"516003"
],
"ucsc_id": "uc064xpj.1"
},
"gene_symbol": "MT-ND4",
"genome_context_intronic_sequence": "",
"hgvs_lrg_transcript_variant": "",
"hgvs_lrg_variant": "",
"hgvs_predicted_protein_consequence": {
"lrg_slr": "",
"lrg_tlr": "",
"slr": "ENSP00000354961.2:p.(L158P)",
"tlr": "ENSP00000354961.2:p.(Leu158Pro)"
},
"hgvs_refseqgene_variant": "",
"hgvs_transcript_variant": "ENST00000361381.2:c.473T>C",
"lovd_corrections": null,
"lovd_messages": null,
"primary_assembly_loci": {
"grch37": {
"hgvs_genomic_description": "NC_012920.1:m.11232T>C",
"vcf": {
"alt": "C",
"chr": "M",
"pos": "11232",
"ref": "T"
}
},
"grch38": {
"hgvs_genomic_description": "NC_012920.1:m.11232T>C",
"vcf": {
"alt": "C",
"chr": "M",
"pos": "11232",
"ref": "T"
}
},
"hg38": {
"hgvs_genomic_description": "NC_012920.1:m.11232T>C",
"vcf": {
"alt": "C",
"chr": "chrM",
"pos": "11232",
"ref": "T"
}
}
},
"reference_sequence_records": {
"protein": "https://www.ensembl.org/Homo_sapiens/Transcript/ProteinSummary?db=core;p=ENSP00000354961.2",
"transcript": "https://www.ensembl.org/Homo_sapiens/Transcript/Summary?db=core;t=ENST00000361381.2"
},
"refseqgene_context_intronic_sequence": "",
"rna_variant_descriptions": null,
"selected_assembly": "GRCh38",
"submitted_variant": "NC_012920.1(MT-ND4):m.11232T>C",
"transcript_description": "ND4-201",
"validation_warnings": [
"VariantSyntaxError: Removing redundant gene symbol none from variant description"
],
"variant_exonic_positions": {}
},
"flag": "gene_variant",
"metadata": {
"variantvalidator_hgvs_version": "4.0.0",
"variantvalidator_version": "4.0.1.dev100+g0f5e4f065.d20260730",
"vvdb_version": "vvdb_2026_7",
"vvseqrepo_db": "VV_SR_2026_07/master",
"vvta_version": "vvta_2026_07"
}
} |
Peter-J-Freeman
force-pushed
the
regex_removal
branch
from
September 22, 2026 12:21
867af59 to
0c16f49
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The relevant transcript mappings have been fixed and the code updated top allow mito genes to produce c. and m. from genomic m.