[18.0-fr6] Deprecate AdminPassword and AdminUsername in HorizonTest CR - #487
Conversation
These fields stored credentials as plaintext in the CR spec. When left empty (the new default), the container reads credentials from the already-mounted clouds.yaml and secure.yaml instead. In the future, these parameters will be removed, so that users set them in clouds.yaml and secure.yaml, creating one source of truth.
kstrenkova
left a comment
kstrenkova
left a comment
There was a problem hiding this comment.
The HorizonTests will not pass without this fix, so it is necessary to add it into fr6.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kstrenkova, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 17m 01s |
|
/override rdoproject.org/github-check The HorizonTest failure is a known issue and this PR is one of the changes helping to fix it. |
|
@kstrenkova: Overrode contexts on behalf of kstrenkova: rdoproject.org/github-check DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
d116add
into
openstack-k8s-operators:18.0-fr6
2 participants
This is an automated cherry-pick of #473
/assign kstrenkova