Deprecate AdminPassword and AdminUsername in HorizonTest CR - #473
Conversation
These fields stored credentials as plaintext in the CR spec. When left empty (the new default), the container reads credentials from the already-mounted clouds.yaml and secure.yaml instead. In the future, these parameters will be removed, so that users set them in clouds.yaml and secure.yaml, creating one source of truth.
c28c133 to
12e8b80
Compare
Parameters adminUsername and adminPassword are being deprecated in the test-operator [1]. Their defaults are also being removed, therefore it is needed to remove them in ci-framework as well. Parameters projectName, user, and password were never fully working in the test-operator, as the values were hardcoded regardless of what was set in the CR. The effort to remove them is in test-operator PR [2], which needs their removal in ci-framework as well. [1] openstack-k8s-operators/test-operator#473 [2] openstack-k8s-operators/test-operator#474 Signed-off-by: Katarina Strenkova <kstrenko@redhat.com>
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 11m 21s |
Parameters adminUsername and adminPassword are being deprecated in the test-operator [1]. Their defaults are also being removed, therefore it is needed to remove them in ci-framework as well. Parameters projectName, user, and password were never fully working in the test-operator, as the values were hardcoded regardless of what was set in the CR. The effort to remove them is in test-operator PR [2], which needs their removal in ci-framework as well. [1] openstack-k8s-operators/test-operator#473 [2] openstack-k8s-operators/test-operator#474 Signed-off-by: Katarina Strenkova <kstrenko@redhat.com>
|
recheck |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 08m 37s |
Parameters adminUsername and adminPassword are being deprecated in the test-operator [1]. Their defaults are also being removed, therefore it is needed to remove them in ci-framework as well. Parameters projectName, user, and password were never fully working in the test-operator, as the values were hardcoded regardless of what was set in the CR. The effort to remove them is in test-operator PR [2], which needs their removal in ci-framework as well. [1] openstack-k8s-operators/test-operator#473 [2] openstack-k8s-operators/test-operator#474 Signed-off-by: Katarina Strenkova <kstrenko@redhat.com>
Parameters adminUsername and adminPassword are being deprecated in the test-operator [1]. Their defaults are also being removed, therefore it is needed to remove them in ci-framework as well. Parameters projectName, user, and password were never fully working in the test-operator, as the values were hardcoded regardless of what was set in the CR. The effort to remove them is in test-operator PR [2], which needs their removal in ci-framework as well. [1] openstack-k8s-operators/test-operator#473 [2] openstack-k8s-operators/test-operator#474 Signed-off-by: Katarina Strenkova <kstrenko@redhat.com>
|
/override rdoproject.org/github-check The HorizonTest failure is a known issue that we are trying to fix with this PR. However, this change needs to get merged first to test the dependent TCIB change, which should fix the problem. |
|
@kstrenkova: Overrode contexts on behalf of kstrenkova: rdoproject.org/github-check DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/apprvoe |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: imatza-rh, kstrenkova The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
807897c
into
openstack-k8s-operators:main
|
/cherry-pick 18-stable |
|
@kstrenkova: new pull request created: #486 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick 18.0-fr6 |
|
@kstrenkova: new pull request created: #487 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
These fields stored credentials as plaintext in the CR spec. When left empty (the new default), the container reads credentials from the already-mounted clouds.yaml and secure.yaml instead.
In the future, these parameters will be removed, so that users set them in clouds.yaml and secure.yaml, creating one source of truth.