Skip to content

openshift-logging-e2e-tests: build and promote the tests extension image - #85176

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
IshwarKanse:logging-e2e-tests-image
Sep 17, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
IshwarKanse:logging-e2e-tests-image

Conversation

@IshwarKanse

@IshwarKanse IshwarKanse commented Sep 15, 2026

Copy link
Copy Markdown
Member

Builds the OpenShift Tests Extension binary from https://github.com/openshift-eng/openshift-logging-e2e-tests into a single image and promotes it as logging/openshift-logging-e2e-tests:main.

Because the image build compiles the binary, the separate build container test and the src-with-deps intermediate image are dropped; ci/prow/images now provides the build signal on PRs.

A follow-up PR (#85177) adds optional e2e-prgate presubmits to the cluster-logging-operator and loki configs that pull this image through the new openshift-observability-logging-e2e-tests step-registry ref and run the operator-specific [PRGate] suites on a cluster from the observability pool. Merging this first lets the branch-ci-openshift-eng-openshift-logging-e2e-tests-main-images postsubmit publish the image so those jobs can be rehearsed.

Generated with make ci-operator-config jobs; make ci-operator-checkconfig passes.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Dp1Dxge5p9yinA3yJggfFt

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2026
@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 38e666ce-4bb7-4240-bf8c-a0a0108047ff

📥 Commits

Reviewing files that changed from the base of the PR and between 8f7f02a and 3e4b658.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift-eng/openshift-logging-e2e-tests/openshift-eng-openshift-logging-e2e-tests-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift-eng/openshift-logging-e2e-tests/openshift-eng-openshift-logging-e2e-tests-main.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

Changes

Logging E2E image publishing

Layer / File(s) Summary
Final image build and promotion
ci-operator/config/openshift-eng/openshift-logging-e2e-tests/openshift-eng-openshift-logging-e2e-tests-main.yaml
Adds a final image build that runs make build, installs the test binary, and publishes openshift-logging-e2e-tests. The intermediate src-with-deps image is excluded from promotion, while the final image is promoted to logging:main.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: kabirbhartirh

Merge Risk: ⚪ Minimal · up to 3e4b6

The final test image is configured to build and promote the intended image; no confirmed merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The authoritative PR diff changes only CI configuration and adds a generated postsubmit job. It adds no Ginkgo or other test declarations, test titles, pod names, timestamps, UUIDs, node names, …
Test Structure And Quality ✅ Passed PASS: The pull request changes only CI configuration and a generated postsubmit job. The authoritative diff contains no Ginkgo test code, It blocks, cluster operations, assertions, or Eventually/Consi…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only CI YAML. It adds an image build and a promotion postsubmit; it does not add or modify Ginkgo tests, test names, or test bodies. Therefore, the MicroShift API and fe…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS — The PR changes only two YAML CI configuration files. It adds an image build, promotion settings, and a postsubmit job. It does not add or modify Ginkgo tests, so the SNO compatibility check is …
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only ci-operator configuration and a generated postsubmit job. The diff adds an image build, binary installation, promotion settings, and CI job metadata. It adds no dep…
Ote Binary Stdout Contract ✅ Passed No explicit stdout-contract failure is introduced. The PR changes only CI image/promotion configuration and a generated postsubmit job; it adds no process-level Go stdout write. The upstream `cmd/main…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request adds only CI YAML configuration and a generated postsubmit job. The authoritative diff contains no Go or other test-source files, no Ginkgo declarations, no IPv4 literals, and no test…
No-Weak-Crypto ✅ Passed PASS. The PR changes only CI configuration and a generated postsubmit job. The added commands build and install the test extension, then promote its image. The only matches for the scan terms are CI c…
Container-Privileges ✅ Passed No explicit container privilege condition is introduced. The changed image config adds Dockerfile build and install commands, plus image promotion. The generated postsubmit pod defines containers, vol…
No-Sensitive-Data-In-Logs ✅ Passed The pull request adds image-build and promotion configuration only. The changed build commands run make build and install a binary; they do not print passwords, tokens, API keys, PII, session IDs, h…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: building and promoting the OpenShift logging E2E tests extension image.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@IshwarKanse

Copy link
Copy Markdown
Member Author

/pj-rehearse

@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@IshwarKanse: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Build the OpenShift Tests Extension binary from openshift-eng/openshift-logging-e2e-tests
into a single image and promote it as logging/openshift-logging-e2e-tests:main, so CI jobs
of the logging operator repositories can run the [PRGate] suites against their PRs.

The image build compiles the binary, so the separate build container test and the
src-with-deps intermediate image are no longer needed; ci/prow/images covers them.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dp1Dxge5p9yinA3yJggfFt
@IshwarKanse
IshwarKanse force-pushed the logging-e2e-tests-image branch from 3e4b658 to e6499ff Compare September 15, 2026 06:30
@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@IshwarKanse: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-eng-openshift-logging-e2e-tests-main-images openshift-eng/openshift-logging-e2e-tests presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@IshwarKanse

Copy link
Copy Markdown
Member Author

/pj-rehearse

@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@IshwarKanse: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@IshwarKanse

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-eng-openshift-logging-e2e-tests-main-images

@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@IshwarKanse: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@IshwarKanse

Copy link
Copy Markdown
Member Author

/pj-reherase ack

@kabirbhartiRH

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2026
@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IshwarKanse, kabirbhartiRH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kabirbhartiRH

Copy link
Copy Markdown
Contributor

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@kabirbhartiRH: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 17, 2026
@IshwarKanse

Copy link
Copy Markdown
Member Author

/retest

@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@IshwarKanse: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit c36777d into openshift:main Sep 17, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants