Skip to content

Add driver-toolkit verify job with qualifier to 4.23 release config - #82829

Open
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:driver-toolkit-qualifier-4.23
Open

Add driver-toolkit verify job with qualifier to 4.23 release config#82829
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:driver-toolkit-qualifier-4.23

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Add a new optional driver-toolkit verify entry to the 4.23 nightly release-controller config.\n\nThe job is gated by the driver-toolkit qualifier (defined globally in release-qualifiers.yaml) and runs periodic-ci-openshift-release-main-nightly-4.23-e2e-aws-driver-toolkit with optional: true and maxRetries: 2.\n\nRegenerated the derived priv release config via make release-controllers.


AI-generated. Review for accuracy.

@neisw requested via Chai Bot

Summary by CodeRabbit

  • Adds an optional driver-toolkit verification job to the OpenShift 4.23 nightly release-controller configuration.
  • Runs periodic-ci-openshift-release-main-nightly-4.23-e2e-aws-driver-toolkit when the global driver-toolkit qualifier is enabled.
  • Allows two retries and does not block release progress.
  • Regenerates the derived private release configuration with make release-controllers.

Add a new optional driver-toolkit verify entry to the 4.23 nightly
release-controller config. The job is gated by the driver-toolkit
qualifier (defined globally in release-qualifiers.yaml) and runs
periodic-ci-openshift-release-main-nightly-4.23-e2e-aws-driver-toolkit
with optional: true and maxRetries: 2.

Regenerated the derived priv release config via 'make release-controllers'.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@redhat-chai-bot: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 3, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 82f61564-df11-45a2-b33e-5366fbc4972f

📥 Commits

Reviewing files that changed from the base of the PR and between ee6b228 and 6b7b4a1.

📒 Files selected for processing (2)
  • core-services/release-controller/_releases/priv/release-ocp-4.23.json
  • core-services/release-controller/_releases/release-ocp-4.23.json

Walkthrough

The release-controller configurations add optional driver-toolkit verification jobs for OpenShift 4.23. The jobs include retry settings, AWS Driver Toolkit Prow job wiring, and a driver-toolkit qualifier. The private configuration keeps the job disabled.

Changes

Driver Toolkit verification

Layer / File(s) Summary
Configure Driver Toolkit verification
core-services/release-controller/_releases/release-ocp-4.23.json, core-services/release-controller/_releases/priv/release-ocp-4.23.json
Both release configurations add the optional verification job, retry settings, AWS Driver Toolkit Prow job, and driver-toolkit qualifier. The private configuration marks the job as disabled.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the addition of the driver-toolkit verification job and qualifier to the 4.23 release configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes only two JSON release configurations. It adds no Ginkgo test declarations or test titles, so the stability check is not applicable.
Test Structure And Quality ✅ Passed The PR changes only two JSON release configs; the diff adds no Ginkgo test code, so the test-structure requirements do not apply.
Microshift Test Compatibility ✅ Passed The commit changes only two release-controller JSON files and adds no Ginkgo test declarations or test files, so MicroShift compatibility checks are not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only two release-controller JSON files; it adds no Ginkgo tests or test code, so SNO compatibility checks do not apply.
Topology-Aware Scheduling Compatibility ✅ Passed The change only adds release-controller JSON verify metadata and a qualifier; it adds no deployment, operator, controller, or scheduling constraints to assess.
Ote Binary Stdout Contract ✅ Passed The commit changes only two release-controller JSON files; it adds no OTE binary or process-level Go suite code that could write non-JSON stdout.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only two JSON release configurations; it adds no Ginkgo test source, IPv4 logic, or external connectivity code.
No-Weak-Crypto ✅ Passed The PR adds only release-controller JSON entries for a driver-toolkit job; the full diff contains no weak-crypto algorithms, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed HEAD changes only two release JSON files; added entries contain no prohibited privilege fields, and the referenced unchanged Prow job has none.
No-Sensitive-Data-In-Logs ✅ Passed The commit adds only JSON job metadata and a qualifier; no logging statements, passwords, tokens, API keys, PII, hostnames, or customer data are introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from joepvd and sosiouxme August 3, 2026 16:35
@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant