Skip to content

Export WORKLOAD_IMAGE in upgrade e2e steps - #82777

Open
ugreener wants to merge 1 commit into
openshift:mainfrom
ugreener:fix/upgrade-workload-image-env
Open

Export WORKLOAD_IMAGE in upgrade e2e steps#82777
ugreener wants to merge 1 commit into
openshift:mainfrom
ugreener:fix/upgrade-workload-image-env

Conversation

@ugreener

@ugreener ugreener commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Problem

The medik8s E2E test infrastructure establishes a single source of truth for the workload image: the medik8s-lib CI step writes it to SHARED_DIR/workload_image, and each e2e-test step exports it as WORKLOAD_IMAGE. This allows the image to be changed in one place (medik8s-lib-commands.sh). The upgrade CI variant's e2e-upgrade-test steps did not export WORKLOAD_IMAGE, so they bypassed the centralized configuration entirely. As a result, upgrade tests silently used a fallback image instead of the shared one, and changing the image in medik8s-lib had no effect on upgrade runs.

Summary

Export WORKLOAD_IMAGE from SHARED_DIR/workload_image in both upgrade e2e-upgrade-test steps (presubmit and periodic), matching the pattern already used across all e2e-test steps in the 4.22-konflux variant (PR #82523).

Changes

  • Updated presubmit e2e-upgrade-test step to export WORKLOAD_IMAGE from SHARED_DIR/workload_image before make run-tests
  • Updated periodic e2e-upgrade-test step with the same pattern

Jira: RHWA-1397

The 4.22-upgrade variant e2e-upgrade-test steps did not export
WORKLOAD_IMAGE from SHARED_DIR/workload_image, causing upgrade tests
to use a fallback image instead of the centrally defined workload
image written by the medik8s-lib step.

Add the same WORKLOAD_IMAGE export pattern used in the 4.22-konflux
variant to both presubmit and periodic e2e-upgrade-test steps.

Jira: RHWA-1397

Co-Authored-By: Claude <noreply@anthropic.com>
@openshift-ci
openshift-ci Bot requested review from maximunited and mpryc August 2, 2026 07:49
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The presubmit and scheduled AWS upgrade test commands now conditionally load SHARED_DIR/workload_image into WORKLOAD_IMAGE before running make run-tests.

Changes

AWS upgrade workload image

Layer / File(s) Summary
Load workload image before upgrade tests
ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-upgrade.yaml
Both AWS upgrade test commands use multiline shell scripts. Each command conditionally reads the shared workload image before running tests.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes only one YAML configuration file to export WORKLOAD_IMAGE; it adds no Ginkgo test titles or dynamic test-name values.
Test Structure And Quality ✅ Passed The commit changes only one CI YAML file and adds WORKLOAD_IMAGE loading to two shell commands; it changes no Ginkgo It blocks or test setup, cleanup, waits, or assertions.
Microshift Test Compatibility ✅ Passed The PR changes only a CI YAML file to set WORKLOAD_IMAGE; it adds no Ginkgo tests or MicroShift-incompatible API references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The patch changes only one CI YAML file and adds no Ginkgo tests or test logic, so SNO compatibility checks do not apply.
Topology-Aware Scheduling Compatibility ✅ Passed The commit changes only CI YAML commands to load WORKLOAD_IMAGE; it adds no manifests, operator code, controllers, replicas, affinities, selectors, tolerations, or other scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The patch changes only CI YAML; it adds shell environment setup before make run-tests and contains no OTE binary or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only YAML commands for WORKLOAD_IMAGE and adds no Ginkgo tests or networking code; the IPv6/disconnected check is not applicable.
No-Weak-Crypto ✅ Passed The only changes load WORKLOAD_IMAGE and run make run-tests; no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret comparisons were introduced.
Container-Privileges ✅ Passed The PR only changes two shell command blocks to load WORKLOAD_IMAGE; no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation setting is added.
No-Sensitive-Data-In-Logs ✅ Passed The changed blocks only read and export WORKLOAD_IMAGE before make run-tests; the sole writer sets a public UBI image, and the diff adds no password, token, PII, or logging call.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes exporting WORKLOAD_IMAGE in the upgrade end-to-end test steps.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@ugreener: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-medik8s-system-tests-main-4.22-upgrade-e2e-far-upgrade-presubmit-aws medik8s/system-tests presubmit Ci-operator config changed
periodic-ci-medik8s-system-tests-main-4.22-upgrade-e2e-far-upgrade-aws N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

ugreener added a commit to ugreener/system-tests that referenced this pull request Aug 2, 2026
Replace the silent fallback to ubi9/ubi-minimal with a panic when
WORKLOAD_IMAGE is unset. This ensures CI misconfiguration (missing
export in e2e-test commands) is caught immediately rather than
silently using a default image.

The fallback was added as a workaround while the upgrade CI variant
lacked the WORKLOAD_IMAGE export. Now that openshift/release PR #82777
adds the export to all e2e-upgrade-test steps, the fallback can be
removed.

Depends-On: openshift/release#82777

Co-Authored-By: Claude <noreply@anthropic.com>
@ugreener

ugreener commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-medik8s-system-tests-main-4.22-upgrade-e2e-far-upgrade-presubmit-aws

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@ugreener: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

@ugreener: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ugreener ugreener changed the title medik8s: export WORKLOAD_IMAGE in upgrade e2e steps Export WORKLOAD_IMAGE in upgrade e2e steps Aug 2, 2026

@razo7 razo7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/pj-rehearse ack

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2026
@openshift-ci

openshift-ci Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, ugreener

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants