ARO-HCP: reuse promoted images for healthchecks - #82772
Conversation
Use promoted e2e runner images and resolve the complete main service image set from ACR instead of rebuilding images in each regional periodic healthcheck. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
WalkthroughChangesARO HCP healthcheck provisioning
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant HealthcheckWorkflow
participant ProvisionFromMain
participant Git
participant ACR
participant GeneratedOverrides
HealthcheckWorkflow->>ProvisionFromMain: start provisioning
ProvisionFromMain->>Git: fetch main or validate PULL_BASE_SHA
ProvisionFromMain->>ACR: verify complete service image set
ACR-->>ProvisionFromMain: return available image manifests
ProvisionFromMain->>ACR: resolve custom exporter digest
ProvisionFromMain->>GeneratedOverrides: write service image overrides
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/aro-hcp/provision/from-main/aro-hcp-provision-from-main-commands.sh`:
- Around line 100-108: Add "${OC_MIRROR_REPO}" to the repository list iterated
by image_set_available in the provisioning command flow, alongside the existing
commit-tagged image repositories. Ensure oc-mirror is validated before the
commit tag is accepted and provisioning proceeds.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: b4d92548-f102-48b1-adf0-4fa1be606014
⛔ Files ignored due to path filters (2)
ci-operator/jobs/Azure/ARO-HCP/Azure-ARO-HCP-main-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/Azure/ARO-HCP/Azure-ARO-HCP-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (4)
ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__periodic-healthcheck.yamlci-operator/step-registry/aro-hcp/provision-healthcheck/aro-hcp-provision-healthcheck-workflow.yamlci-operator/step-registry/aro-hcp/provision/from-main/aro-hcp-provision-from-main-commands.shci-operator/step-registry/aro-hcp/provision/from-main/aro-hcp-provision-from-main-ref.yaml
| for repo in \ | ||
| "${BACKEND_REPO}" \ | ||
| "${FRONTEND_REPO}" \ | ||
| "${ADMIN_API_REPO}" \ | ||
| "${SESSIONGATE_REPO}" \ | ||
| "${FLEET_REPO}" \ | ||
| "${MGMT_AGENT_REPO}" \ | ||
| "${KUBE_APPLIER_REPO}" \ | ||
| "${EXPORTER_REPO}"; do |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Validate the oc-mirror image before accepting the commit tag.
Add ${OC_MIRROR_REPO} to image_set_available. The images-push step publishes oc-mirror with the same commit-derived tag. This loop can otherwise accept a partial image set and start provisioning before oc-mirror is available.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/step-registry/aro-hcp/provision/from-main/aro-hcp-provision-from-main-commands.sh`
around lines 100 - 108, Add "${OC_MIRROR_REPO}" to the repository list iterated
by image_set_available in the provisioning command flow, alongside the existing
commit-tagged image repositories. Ensure oc-mirror is validated before the
commit tag is accepted and provisioning proceeds.
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
1 participant
Summary
aro-hcp-e2e-testsandaro-hcp-e2e-toolsimages in regional healthcheck periodicsaro-hcp-provision-from-mainand wait for every required ACR imageperiodic-healthcheck-imagespresubmitValidation
make jobs WHAT=Azure/ARO-HCPmake ci-operator-checkconfig SKIP_PULL=truecheckconfigforci-operator/jobs/Azure/ARO-HCPbash -n ci-operator/step-registry/aro-hcp/provision/from-main/aro-hcp-provision-from-main-commands.shSummary by CodeRabbit
aro-hcp-e2e-testsandaro-hcp-e2e-toolsimages.maininstead of rebuilding service images.aro-hcp-provision-from-mainand waits for all required service images, includingcustomExporter.periodic-healthcheck-imagespresubmit and updates workflow documentation.mainfetching for periodic and rehearsal jobs while using validatedPULL_BASE_SHAfor presubmit jobs.