Skip to content

setup assisted-installer version v2.55 - #82739

Closed
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-496ae8c7-38e7-4081-b096-085ebcfb8ef2
Closed

setup assisted-installer version v2.55#82739
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-496ae8c7-38e7-4081-b096-085ebcfb8ef2

Conversation

@danmanor

@danmanor danmanor commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Updates OpenShift CI configuration for Assisted Installer v2.55 and Assisted Installer Agent v2.55.
  • Makes the subsystem-test and e2e-metal-assisted jobs opt-in by setting always_run: false.
  • Moves conditional skip rules to pipeline_skip_if_only_changed for documentation-only and configuration-only changes.

@openshift-ci
openshift-ci Bot requested review from eliorerz and giladravid16 July 31, 2026 15:31
@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 71f05611-0d23-4f0f-86ca-24a13762dc13

📥 Commits

Reviewing files that changed from the base of the PR and between bd26f2f and 07df0d4.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yaml

Walkthrough

The assisted installer test configurations now set always_run: false and replace skip_if_only_changed with pipeline_skip_if_only_changed while preserving the existing filter pattern.

Changes

Assisted installer test scheduling

Layer / File(s) Summary
Test scheduling configuration
ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yaml, ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yaml
The test entries disable unconditional execution and apply the existing change filters at the pipeline level.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the assisted-installer version setup and matches the main change in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The patch changes only static CI job names and skip annotations; it adds no Ginkgo titles or dynamic values such as pods, nodes, namespaces, timestamps, UUIDs, or IPs.
Test Structure And Quality ✅ Passed The pull request changes four YAML CI configuration files only; it adds no Go or Ginkgo test code, so the listed Ginkgo quality checks are not applicable.
Microshift Test Compatibility ✅ Passed The commit changes only four CI YAML files and adds no Ginkgo tests or test code requiring MicroShift API compatibility review.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR modifies only CI operator YAML configuration files with no changes to Ginkgo test code. It adds no new tests that could have SNO compatibility issues.
Topology-Aware Scheduling Compatibility ✅ Passed Modified files are CI operator configuration files in ci-operator/config/, not deployment manifests, operator code, or controllers. They contain only test job and pipeline definitions with no Kuber...
Ote Binary Stdout Contract ✅ Passed Pull request contains only YAML CI/CD configuration changes to assisted-installer project settings; no Go test code was modified, making the OTE Binary Stdout Contract check inapplicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only CI configuration and generated presubmit YAML; it adds no Ginkgo tests, networking code, IPv4 assumptions, or external connectivity.
No-Weak-Crypto ✅ Passed PR modifies only YAML CI/CD configuration files. No cryptographic algorithms, custom crypto implementations, or secret comparisons are present. Check not applicable.
Container-Privileges ✅ Passed The diff changes only scheduling and skip annotations. No changed file adds privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root security settings.
No-Sensitive-Data-In-Logs ✅ Passed The pull request modifies only CI configuration files with no new logging statements or code that exposes passwords, tokens, API keys, PII, or other sensitive data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@danmanor: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-installer-v2.55-e2e-metal-assisted openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted openshift/assisted-installer-agent presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-subsystem-test openshift/assisted-installer-agent presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danmanor

danmanor commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Closing as duplicate of #82771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants