Skip to content

Add hook-reverse-proxy image - #82736

Open
danilo-gemoli wants to merge 2 commits into
openshift:mainfrom
danilo-gemoli:feat/ci-tools/add-hook-reverse-proxy-img
Open

Add hook-reverse-proxy image#82736
danilo-gemoli wants to merge 2 commits into
openshift:mainfrom
danilo-gemoli:feat/ci-tools/add-hook-reverse-proxy-img

Conversation

@danilo-gemoli

@danilo-gemoli danilo-gemoli commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Continuation openshift/ci-tools#5345

Summary by CodeRabbit

Adds the hook-reverse-proxy image to the OpenShift CI tools release configuration. The image builds from os using /go/bin/hook-reverse-proxy.

@openshift-ci
openshift-ci Bot requested review from hector-vido and smg247 July 31, 2026 14:51
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2026
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/ci-tools/openshift-ci-tools-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/ci-tools/openshift-ci-tools-main-presubmits.yaml is excluded by !ci-operator/jobs/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: fce99bb0-4170-449c-a118-1c03eb616f56

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

This change adds a new image entry, hook-reverse-proxy, to the CI configuration file. The image builds from the os base image and includes the /go/bin/hook-reverse-proxy binary.

Changes

CI Image Configuration

Layer / File(s) Summary
Add hook-reverse-proxy image definition
ci-operator/config/openshift/ci-tools/openshift-ci-tools-main.yaml
Adds the hook-reverse-proxy image to images.items, built from os with the /go/bin/hook-reverse-proxy binary.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: deepsm007, jmguzik

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the addition of the hook-reverse-proxy image.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR modifies only a CI/CD configuration file (openshift-ci-tools-main.yaml) to add a container image build definition. It does not contain any Ginkgo test code, test names, or dynamic test ident...
Test Structure And Quality ✅ Passed The patch changes only one YAML image configuration file and adds no Ginkgo tests or cluster operations for this check to assess.
Microshift Test Compatibility ✅ Passed The pull request changes only a YAML image configuration; it adds no Ginkgo tests, OpenShift API references, namespaces, or MicroShift-unsupported assumptions.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only one YAML image configuration; it adds no Ginkgo tests or multi-node assumptions, so the SNO check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The only change adds an image-build entry to a CI YAML file; it adds no deployment manifest, operator code, controller, replica, affinity, topology, node, or PDB scheduling constraint.
Ote Binary Stdout Contract ✅ Passed PR contains only YAML configuration changes to ci-operator image build config; no Go source code modifying process-level code. OTE Stdout Contract check applies to source code only.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR only adds a declarative YAML image entry; it adds no Ginkgo tests, IPv4 assumptions, or external connectivity.
No-Weak-Crypto ✅ Passed The PR adds only a CI/CD image configuration (8 lines) to a YAML file. No cryptographic code, implementations, or secret comparisons are present in the changes.
Container-Privileges ✅ Passed The only changed file adds an image build entry; it contains no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The commit changes only eight YAML lines that register an image and binary path; it adds no logging statements or sensitive values.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@danilo-gemoli: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-ci-tools-main-breaking-changes openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-checkconfig openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-codegen openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-e2e openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-e2e-oo openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-format openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-frontend-checks openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-images openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-integration openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-lint openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-security openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-unit openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-validate-prow openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-validate-vendor openshift/ci-tools presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@danilo-gemoli: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-ci-tools-main-breaking-changes openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-checkconfig openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-codegen openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-e2e openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-e2e-oo openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-format openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-frontend-checks openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-images openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-integration openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-lint openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-security openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-unit openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-validate-prow openshift/ci-tools presubmit Ci-operator config changed
pull-ci-openshift-ci-tools-main-validate-vendor openshift/ci-tools presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@danilo-gemoli: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant