cnv/virt-cluster-validate: Install dependency operators and Azure RWX storage - #82726
cnv/virt-cluster-validate: Install dependency operators and Azure RWX storage#82726tiraboschi wants to merge 1 commit into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAzure and GCP validation workflows install NMState, OADP, Node Health Check, and Self Node Remediation from v4.22 catalogs. Azure configures Azure Files SMB storage and enables host-network and live-migration validation. GCP enables host-network validation. Both workflows archive JUnit results. ChangesCloud validation workflows
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant CloudWorkflow
participant CatalogSource
participant OperatorInstallation
participant Validation
participant ResultsArchive
CloudWorkflow->>CatalogSource: Create v4.22 CatalogSource and wait for readiness
CloudWorkflow->>OperatorInstallation: Install configured operators
CloudWorkflow->>Validation: Run enabled cloud validation checks
Validation->>ResultsArchive: Copy JUnit results
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-cnv/virt-cluster-validate/openshift-cnv-virt-cluster-validate-main.yaml`:
- Around line 39-45: Remove the skip_checking property from every operator entry
in the OPERATORS definitions at
ci-operator/config/openshift-cnv/virt-cluster-validate/openshift-cnv-virt-cluster-validate-main.yaml
lines 39-45 and lines 153-159, including the Azure and GCP operator entries, so
installation failures stop validation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 223d21c4-bf74-45b4-a12c-e5ededdb00b4
📒 Files selected for processing (1)
ci-operator/config/openshift-cnv/virt-cluster-validate/openshift-cnv-virt-cluster-validate-main.yaml
6e2d012 to
b607717
Compare
|
/pj-rehearse |
|
@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
b607717 to
33f621c
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-cnv/virt-cluster-validate/openshift-cnv-virt-cluster-validate-main.yaml`:
- Line 115: Remove the trailing `|| true` from the storage-class clearing
command so failures from `oc get` or `oc patch` propagate and stop validation.
Update the command around the `oc get storageclass` pipeline while preserving
the existing patch operation and annotation target.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 8f12653f-2324-4458-9308-4965de11272b
📒 Files selected for processing (1)
ci-operator/config/openshift-cnv/virt-cluster-validate/openshift-cnv-virt-cluster-validate-main.yaml
|
/pj-rehearse |
|
@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
33f621c to
fe1d09c
Compare
|
/pj-rehearse pull-ci-openshift-cnv-virt-cluster-validate-main-e2e-azure |
|
@tiraboschi, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-cnv/virt-cluster-validate/openshift-cnv-virt-cluster-validate-main.yaml`:
- Around line 120-133: Update the StorageClass definition to use the name
azurefile-csi-nfs, set parameters.protocol to nfs, and change skuName to the
supported Premium_LRS value. Adjust the StorageProfile wait and patch commands
to reference azurefile-csi-nfs, including the expected provisioner and existing
claim property settings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 9249b976-ce23-439d-8d4e-f33d9f48095a
📒 Files selected for processing (1)
ci-operator/config/openshift-cnv/virt-cluster-validate/openshift-cnv-virt-cluster-validate-main.yaml
fe1d09c to
6b2d989
Compare
|
/pj-rehearse pull-ci-openshift-cnv-virt-cluster-validate-main-e2e-azure |
|
@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
… storage Pre-install nmstate, OADP, NHC, and SNR operators via the install-operators step-registry ref on both e2e-azure and e2e-gcp lanes. This reduces test skips (OADP/backup) and warnings (node remediation) that previously fired because these operators were absent. Since OCP 5.0 nightlies may not have all operators in the default redhat-operators catalog, a custom CatalogSource is created from the v4.22 redhat-operator-index (the last released OCP version). On Azure, create an azurefile-csi-nfs StorageClass annotated as the default virt class (storageclass.kubevirt.io/is-default-virt-class), enabling the live-migration check that was previously skipped due to RWO-only storage. Also surface junit-results.xml in CI artifacts for Spyglass rendering. GCP RWX storage is left for a follow-up: it requires the gcp-filestore-csi-driver-operator subscription, a ClusterCSIDriver object, and a storage-destroy-csi-gcp-filestore post step for cleanup. Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
6b2d989 to
88fdcb6
Compare
|
/pj-rehearse pull-ci-openshift-cnv-virt-cluster-validate-main-e2e-azure |
|
@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
1 participant
Pre-install nmstate, OADP, NHC, and SNR operators via the install-operators step-registry ref on both e2e-azure and e2e-gcp lanes. This reduces test skips (OADP/backup) and warnings (node remediation) that previously fired because these operators were absent.
On Azure, create an azurefile-csi-nfs StorageClass annotated as the default virt class (storageclass.kubevirt.io/is-default-virt-class), enabling the live-migration check that was previously skipped due to RWO-only storage.
Also surface junit-results.xml in CI artifacts for Spyglass rendering.
GCP RWX storage is left for a follow-up: it requires the gcp-filestore-csi-driver-operator subscription, a ClusterCSIDriver object, and a storage-destroy-csi-gcp-filestore post step for cleanup.
Summary by CodeRabbit
azurefile-csi-nfsStorageClass and enables live-migration validation.junit-results.xmlin both workflows for Spyglass rendering.