ROSAENG-59003 | chore: Clusters cleaner prow onboarding

[jfrazierRedHat]

Summary by CodeRabbit

This PR onboards openshift-online/rosa-clusters-cleaner to OpenShift CI and Prow for the master branch:

• Adds a CI-operator configuration that runs make test in a src container with standard resource settings and the configured release build image.
• Adds Prow settings for approvals, LGTM behavior, trusted apps, repository plugins, and external automation such as refresh, cherrypick, needs-rebase, and backport verification.
• Adds a Tide query that requires approved and lgtm labels and excludes blocked or invalid pull requests.
• Adds repository ownership rules with approver and reviewer lists.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

Adds master-branch CI configuration, repository ownership, and repository-scoped Prow plugin, trigger, and Tide settings for openshift-online/rosa-clusters-cleaner.

Changes

rosa-clusters-cleaner repository onboarding

Layer / File(s)	Summary
CI and ownership configuration ci-operator/config/openshift-online/rosa-clusters-cleaner/*	Defines repository approvers and reviewers, the build image, resource defaults, prowgen settings, repository metadata, and a make test step.
Prow governance configuration core-services/prow/02_config/openshift-online/rosa-clusters-cleaner/*	Registers repository plugins and external event handlers, restricts trusted applications, and requires approved and lgtm labels while excluding configured blocking labels from Tide matching.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• openshift/release#82745: Adds similar repository onboarding configuration.
• openshift/release#82784: Adds repository approver and reviewer metadata.
• openshift/release#82795: Adds repository-specific Prow plugin and Tide configuration.

Suggested labels: rehearsals-ack

Suggested reviewers: psalajova, deepsm007

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: onboarding the clusters cleaner repository to Prow.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR adds only CI/Prow YAML and OWNERS files; no Ginkgo declarations or test source files are present, so no unstable test title is introduced.
Test Structure And Quality	✅ Passed	The PR adds only CI/Prow YAML and OWNERS files; the diff contains no Ginkgo test code, It blocks, cluster operations, or assertions to review.
Microshift Test Compatibility	✅ Passed	The PR changes only CI/Prow YAML and OWNERS files; the diff adds no Go/Ginkgo tests or It, Describe, Context, or When declarations, so MicroShift compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The effective PR diff adds or updates CI/Prow YAML only; it adds no Ginkgo e2e tests and contains no multi-node or HA assumptions to assess.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR adds only CI/Prow configuration, generated presubmits, and OWNERS files; it introduces no deployment, operator, controller, or topology scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only CI/Prow YAML and OWNERS files; it adds no OTE binary or process-level code and contains no stdout writes to flag.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The source commit adds only CI/Prow YAML and OWNERS files; it adds no Ginkgo tests or test networking code requiring IPv4 or external connectivity.
No-Weak-Crypto	✅ Passed	The PR changes only CI/Prow YAML and OWNERS files; the diff and all changed files contain no MD5, SHA1, DES, RC4, Blowfish, ECB, or custom crypto/comparison code.
Container-Privileges	✅ Passed	The added CI and Prow configurations, plus the generated presubmit, contain no privileged mode, hostPID/hostNetwork/hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root-user declaration.
No-Sensitive-Data-In-Logs	✅ Passed	The PR adds no logging or output of sensitive data; the generated job contains only standard secret references and paths, with no secret values, tokens, PII, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/openshift-online/rosa-clusters-cleaner/openshift-online-rosa-clusters-cleaner-master.yaml`:
- Around line 16-24: Regenerate the CI Operator artifacts for the new test
configuration by running the repository’s make update/make jobs target, ensuring
generated ci-operator/jobs entries for openshift-online/rosa-clusters-cleaner
are created and committed alongside the source config.

In
`@core-services/prow/02_config/openshift-online/rosa-clusters-cleaner/_pluginconfig.yaml`:
- Around line 1-4: Update the approve configuration for repository
openshift-online/rosa-clusters-cleaner so require_self_approval is set to true,
matching the required ROSA plugin approval policy.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: fef5d687-39d1-4c65-89a2-abedc26e6d88

📥 Commits

Reviewing files that changed from the base of the PR and between c9e2c31 and 0064330.

📒 Files selected for processing (3)

• ci-operator/config/openshift-online/rosa-clusters-cleaner/openshift-online-rosa-clusters-cleaner-master.yaml
• core-services/prow/02_config/openshift-online/rosa-clusters-cleaner/_pluginconfig.yaml
• core-services/prow/02_config/openshift-online/rosa-clusters-cleaner/_prowconfig.yaml

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Require self-approval for this ROSA repository.

Set require_self_approval to true; false does not match the ROSA GitLab review strategy and weakens the repository’s approval policy.

Proposed fix

-  require_self_approval: false
+  require_self_approval: true

Based on learnings, ROSA-owned plugin configurations under core-services/prow/02_config/openshift-online must set approve.require_self_approval: true.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	approve:
	- repos:
	- openshift-online/rosa-clusters-cleaner
	require_self_approval: false
	approve:
	- repos:
	- openshift-online/rosa-clusters-cleaner
	require_self_approval: true

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@core-services/prow/02_config/openshift-online/rosa-clusters-cleaner/_pluginconfig.yaml`
around lines 1 - 4, Update the approve configuration for repository
openshift-online/rosa-clusters-cleaner so require_self_approval is set to true,
matching the required ROSA plugin approval policy.

Source: Learnings

[jfrazierRedHat]

/pj-rehearse pull-ci-openshift-online-rosa-clusters-cleaner-master-test

[openshift-merge-bot]

@jfrazierRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[gacalixto]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gacalixto, jfrazierRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[jfrazierRedHat]

/pj-rehearse pull-ci-openshift-online-rosa-clusters-cleaner-master-test

[openshift-merge-bot]

@jfrazierRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jfrazierRedHat]

/test test

[jfrazierRedHat]

/retest

[psalajova]

@jfrazierRedHat hi, based on the rehearsal failure, you need to fix your Makefile's test target to point to the correct package path, likely go test ./... instead of go test ./test/..., or whatever directory actually contains your tests

[jfrazierRedHat]

/retest

[jfrazierRedHat]

/pj-rehearse pull-ci-openshift-online-rosa-clusters-cleaner-master-test

[openshift-merge-bot]

@jfrazierRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jfrazierRedHat]

/pj-rehearse pull-ci-openshift-online-rosa-clusters-cleaner-master-test

[openshift-merge-bot]

@jfrazierRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

@jfrazierRedHat: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

[jfrazierRedHat]

/pj-rehearse pull-ci-openshift-online-rosa-clusters-cleaner-master-test

[openshift-merge-bot]

@jfrazierRedHat: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

[jfrazierRedHat]

/pj-rehearse pull-ci-openshift-online-rosa-clusters-cleaner-master-test

[openshift-merge-bot]

@jfrazierRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jfrazierRedHat]

/pj-rehearse ack

[openshift-merge-bot]

@jfrazierRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jfrazierRedHat]

/pj-rehearse pull-ci-openshift-online-rosa-clusters-cleaner-master-test

[openshift-merge-bot]

@jfrazierRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jfrazierRedHat]

/pj-rehearse pull-ci-openshift-online-rosa-clusters-cleaner-master-test

[openshift-merge-bot]

@jfrazierRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jfrazierRedHat]

/retest

[jfrazierRedHat]

/pj-rehearse pull-ci-openshift-online-rosa-clusters-cleaner-master-test

[openshift-merge-bot]

@jfrazierRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@jfrazierRedHat: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-online-rosa-clusters-cleaner-master-test	openshift-online/rosa-clusters-cleaner	presubmit	Presubmit changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[jfrazierRedHat]

/pj-rehearse pull-ci-openshift-online-rosa-clusters-cleaner-master-test

[openshift-merge-bot]

@jfrazierRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@jfrazierRedHat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift-online/rosa-clusters-cleaner/master/test	40c4ba2	link	unknown	/pj-rehearse pull-ci-openshift-online-rosa-clusters-cleaner-master-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.