USHIFT-7167: Update ami references#80025
Conversation
Vendoring was dropped from the lvm-operator release-4.14 branch in OCPEDGE-1638, but the CI config was never updated to match. The builder image sets GOFLAGS=-mod=vendor by default, which causes all PRs to fail with "go: inconsistent vendoring". Remove `go mod vendor` from test_binary_build_commands and unset GOFLAGS in verify, unit-test, and e2e jobs so Go uses module download mode instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@pacevedom: This pull request references USHIFT-7167 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
approved
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR adds ChangesLVM Operator GOFLAGS Environment Setup
MicroShift RHEL OS Version Updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/microshift/openshift-microshift-release-4.22__periodics.yaml`:
- Line 176: The periodic job fails because MICROSHIFT_OS rhel-9.8 is not in the
allowed_os whitelist used by the clusterbot step; update the allowed_os
definition in
ci-operator/step-registry/openshift/microshift/clusterbot/openshift-microshift-clusterbot-commands.sh
to include "rhel-9.8" (or broaden the validation to accept rhel-9.x) so the
script accepts the new OS value referenced by the periodic config; modify the
allowed_os array (or validation logic) accordingly and ensure any conditional
checks that reference allowed_os include the new entry.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 24c16d93-f9ea-430a-a66d-e67453e98a03
📒 Files selected for processing (5)
ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-release-4.14.yamlci-operator/config/openshift/microshift/openshift-microshift-main.yamlci-operator/config/openshift/microshift/openshift-microshift-release-4.22.yamlci-operator/config/openshift/microshift/openshift-microshift-release-4.22__periodics.yamlci-operator/step-registry/openshift/microshift/infra/aws/ec2/openshift-microshift-infra-aws-ec2-commands.sh
|
/pj-rehearse more |
|
@pacevedom: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@pacevedom it looks good, but do you think we should include this changes about cluster bot on this PR or on a separate one? |
Add RHEL 9.8 and RHEL 10.2 as supported OS versions for MicroShift cluster-bot provisioning. AMI IDs are placeholders until these versions become available in the AWS Marketplace. Make the RHEL version in prepare-host repo URLs dynamic, derived from MICROSHIFT_OS instead of hardcoded to el9/rhel-9, so RHEL 10 installs use the correct repository paths. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> pre-commit.check-secrets: ENABLED
|
/lgtm |
|
/pj-rehearse more |
|
@pacevedom: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon, pacevedom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
A total of 351 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@pacevedom: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Summary by CodeRabbit
This PR updates OpenShift CI infrastructure (ci-operator jobs and step-registry scripts) to add and use newer RHEL images for MicroShift and to make related cluster-bot/prepare-host logic compatible with multiple RHEL major versions. It also contains a small CI test environment fix for the lvm-operator jobs.
What changed in practical terms:
Notes: