MGMT-24454: update CAPOA CI build root to Go 1.26.2#80022
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@shay23bra: This pull request references MGMT-24454 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughBumps the Go toolchain reference from 1.25.x to 1.26.x: Dockerfile snippet now installs Go 1.26.2, and two CI build_root image_stream_tag entries are updated to ChangesGo Toolchain & build_root tag updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-assisted/cluster-api-provider-openshift-assisted/openshift-assisted-cluster-api-provider-openshift-assisted-master.yaml`:
- Around line 22-25: The Dockerfile snippet is attempting to fetch go1.26.2
which isn't available; update the tarball URL to a valid released Go binary
(e.g., change go1.26.2.linux-amd64.tar.gz to a released patch like
go1.26.4.linux-amd64.tar.gz) or instead align the toolchain with the module's
declared version by reverting to Go 1.25.x to match the repository go.mod;
ensure the wget target and all subsequent references (the wget line and the tar
-C /usr/local -xzf invocation) use the same valid tarball name so the download
and extraction succeed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: dbe5f985-b2c6-46f9-bd73-f4063a695377
📒 Files selected for processing (1)
ci-operator/config/openshift-assisted/cluster-api-provider-openshift-assisted/openshift-assisted-cluster-api-provider-openshift-assisted-master.yaml
| wget -q https://go.dev/dl/go1.26.2.linux-amd64.tar.gz && \ | ||
| rm -rf /usr/local/go && \ | ||
| tar -C /usr/local -xzf go1.25.5.linux-amd64.tar.gz && \ | ||
| rm -f go1.25.5.linux-amd64.tar.gz && \ | ||
| tar -C /usr/local -xzf go1.26.2.linux-amd64.tar.gz && \ | ||
| rm -f go1.26.2.linux-amd64.tar.gz && \ |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify Go 1.26.2 tarball exists and check upstream go.mod Go version requirement
echo "=== Checking Go 1.26.2 availability ==="
curl -I -s -o /dev/null -w "%{http_code}" https://go.dev/dl/go1.26.2.linux-amd64.tar.gz | grep -q "^200$" && \
echo "✓ Go 1.26.2 tarball is available" || \
echo "✗ Go 1.26.2 tarball not found (HTTP status not 200)"
echo ""
echo "=== Checking upstream go.mod Go version ==="
if [[ -f go.mod ]]; then
echo "Found go.mod in openshift/release repo (not the upstream repo being tested)"
fi
# Check the upstream repo's go.mod by cloning it temporarily
TEMP_DIR=$(mktemp -d)
cd "$TEMP_DIR"
git clone --depth 1 https://github.com/openshift-assisted/cluster-api-provider-openshift-assisted.git
cd cluster-api-provider-openshift-assisted
if [[ -f go.mod ]]; then
GO_VERSION=$(rg -n '^go\s+' go.mod | head -1)
echo "Upstream go.mod declares: $GO_VERSION"
if echo "$GO_VERSION" | grep -q "1.26"; then
echo "✓ Upstream requires Go 1.26"
else
echo "✗ Upstream does not require Go 1.26"
fi
else
echo "✗ No go.mod found in upstream repo"
fi
cd /
rm -rf "$TEMP_DIR"Repository: openshift/release
Length of output: 410
🌐 Web query:
What is the latest Go 1.26 version available as of June 2026?
💡 Result:
As of June 3, 2026, the latest Go 1.26 version available is go1.26.4, which was released on June 2, 2026 [1]. This version includes security fixes for the crypto/x509, mime, and net/textproto packages, along with various bug fixes [1].
Citations:
Go toolchain bump to 1.26.2 is likely broken (missing tarball) and may not match upstream requirements
- This config downloads
go1.26.2.linux-amd64.tar.gz(lines 22-25), but go.dev does not serve that tarball (non-200 response), so the build environment may fail. - The upstream
cluster-api-provider-openshift-assistedgo.modcurrently declaresgo 1.25.0, so the Go 1.26 update should be aligned with upstream (and the referenced upstream PR#717).
Consider switching to an actually released Go 1.26.x tarball (e.g., go1.26.4) or aligning the toolchain version with the upstream go.mod.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift-assisted/cluster-api-provider-openshift-assisted/openshift-assisted-cluster-api-provider-openshift-assisted-master.yaml`
around lines 22 - 25, The Dockerfile snippet is attempting to fetch go1.26.2
which isn't available; update the tarball URL to a valid released Go binary
(e.g., change go1.26.2.linux-amd64.tar.gz to a released patch like
go1.26.4.linux-amd64.tar.gz) or instead align the toolchain with the module's
declared version by reverting to Go 1.25.x to match the repository go.mod;
ensure the wget target and all subsequent references (the wget line and the tar
-C /usr/local -xzf invocation) use the same valid tarball name so the download
and extraction succeed.
|
/pj-rehearse |
|
@shay23bra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-assisted-cluster-api-provider-openshift-assisted-master-unit |
|
@rccrdpccl: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-assisted-cluster-api-provider-openshift-assisted-master-e2e-capi-multinode |
|
@rccrdpccl: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
shay23bra
force-pushed
the
MGMT-24454-upgrade-golang-1.26-capoa
branch
from
b8991c9 to
e5e4e7c
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shay23bra The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-assisted-cluster-api-provider-openshift-assisted-master-e2e-capi-multinode |
|
@rccrdpccl: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@shay23bra: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Summary
https://redhat.atlassian.net/browse/MGMT-24454