Skip to content

Crucible Network dataplane test (iperf) TCP and UDP#79998

Open
smandaRH wants to merge 1 commit into
openshift:mainfrom
smandaRH:crucible
Open

Crucible Network dataplane test (iperf) TCP and UDP#79998
smandaRH wants to merge 1 commit into
openshift:mainfrom
smandaRH:crucible

Conversation

@smandaRH
Copy link
Copy Markdown
Contributor

@smandaRH smandaRH commented Jun 2, 2026

Summary by CodeRabbit

This PR adds two new weekly performance testing jobs to the OpenShift CI infrastructure for RHO-SO (Red Hat OpenStack) deployments. Specifically, it introduces:

  • weekly-rhoso-crucible-udp - A weekly test job running Crucible network dataplane (iperf) tests using UDP protocol
  • weekly-rhoso-crucible-tcp - A weekly test job running Crucible network dataplane (iperf) tests using TCP protocol

Both jobs are scheduled identically to run every Saturday at 5 PM UTC on the metal-perfscale-osp cluster profile. They provision 17 RHEL 9.4 nodes and execute a standard test workflow that includes:

  1. Environment setup and preparation (installer, pre-provisioning)
  2. Browbeat performance testing tool installation and execution
  3. Results backup and reporting

The jobs differ only in the workload type (crucible-udp vs crucible-tcp), allowing continuous performance validation of both TCP and UDP network dataplane performance for OpenShift on OpenStack infrastructure. This enables the performance and scale testing team to track network dataplane performance characteristics across both protocol types on a regular basis.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3cf12cb3-1c58-4b64-baad-90df6306d2a8

📥 Commits

Reviewing files that changed from the base of the PR and between 6451c5c and 81a0032.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__metal-rhoso-x86.yaml

Walkthrough

Two new weekly scheduled CI jobs for Metal RHO-SO performance testing are added: weekly-rhoso-crucible-udp and weekly-rhoso-crucible-tcp. Both jobs share identical configuration including cron schedule, cluster profile, RHEL 9.4 environment with 17 nodes, and test orchestration, differing only in workload variant.

Changes

Metal RHO-SO Crucible Test Jobs

Layer / File(s) Summary
Weekly Crucible UDP and TCP test jobs
ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__metal-rhoso-x86.yaml
Added weekly-rhoso-crucible-udp and weekly-rhoso-crucible-tcp scheduled jobs with shared configuration (Saturday 17:00 UTC cron, metal-perfscale-osp cluster, RHEL 9.4, 17 nodes) and identical test refs, differing only by WORKLOAD type (crucible-udp vs crucible-tcp).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

rehearsals-ack

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding Crucible network dataplane tests for TCP and UDP protocols to the CI configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR only modifies CI configuration YAML files and documentation; it contains no Ginkgo test code (It/Describe/Context/When), making the check inapplicable.
Test Structure And Quality ✅ Passed The PR modifies only a YAML CI configuration file that defines test job parameters. The custom check requires Ginkgo test code review, which is not present in this PR.
Microshift Test Compatibility ✅ Passed This PR adds CI job configuration (YAML) only, not Ginkgo e2e tests. The check applies only to new Ginkgo tests, so it's not applicable here.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds CI job configuration (YAML only), not new Ginkgo e2e test code. SNO compatibility check applies only to new test code additions.
Topology-Aware Scheduling Compatibility ✅ Passed File is a ci-operator test configuration, not a deployment manifest, operator code, or controller. Custom check scope does not apply.
Ote Binary Stdout Contract ✅ Passed PR only modifies YAML CI configuration; no Go source code changes present, making OTE stdout contract check inapplicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only adds CI job configuration to YAML file; no new Ginkgo e2e tests added. The check does not apply as it is specific to "when new Ginkgo e2e tests are added."
No-Weak-Crypto ✅ Passed Pull request modifies only a YAML CI configuration file with no cryptographic code, weak crypto algorithms, custom implementations, or secret comparisons.
Container-Privileges ✅ Passed File is a CI configuration, not a K8s manifest. No privilege escalation indicators found (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation).
No-Sensitive-Data-In-Logs ✅ Passed The PR adds two CI job configurations with no exposed passwords, tokens, API keys, PII, or other sensitive data. Environment variables and logging references are standard CI/CD metadata.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smandaRH
Once this PR has been reviewed and has the lgtm label, please assign afcollins for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from mcornea and paigerube14 June 2, 2026 19:28
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@smandaRH: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.
The following jobs are not rehearsable without the network-access-rehearsals-ok, and approved labels present on this PR. This is due to the restrict_network_access field being set to false. The network-access-rehearsals-ok label can be added by any openshift org member other than the PR's author by commenting: /pj-rehearse network-access-allowed:

Test name
periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-metal-rhoso-x86-weekly-rhoso-crucible-tcp
periodic-ci-openshift-eng-ocp-qe-perfscale-ci-main-metal-rhoso-x86-weekly-rhoso-crucible-udp

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 2, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 2, 2026

@smandaRH: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant