OPCT-420: Add OPCT conformance upgrade periodic jobs for platform-external on AWS#79992
Conversation
|
Hi @redhat-chai-bot. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
WalkthroughThis PR adds the same ChangesOPCT External AWS Upgrade Tests
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/assign @mtulio |
|
@redhat-chai-bot: This pull request references OPCT-420 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-4.19-upgrade-from-stable-4.18.yaml`:
- Around line 167-182: This job declares OPCT_RUN_MODE=upgrade and
UPGRADE_TO_CHANNEL_TYPE=candidate but reviewers noted you must ensure the
composed workflow opct-conformance-external-aws -> opct-conformance-test runs
the expected pre/setup and upgrade flow and that CCM is explicitly disabled;
verify opct-pre (opct-pre-setup-commands.sh) consumes OPCT_RUN_MODE and builds
upgrade_to_channel from UPGRADE_TO_CHANNEL_TYPE, ensure
opct-conformance-test-run-commands.sh uses OPCT_RUN_MODE to switch to
--mode=upgrade and the computed TARGET_RELEASE_IMAGE, and add or confirm
PLATFORM_EXTERNAL_CCM_ENABLED: "no" in the job env to match the CCM intent (and
update any commit/description that says “with CCM” to reflect CCM is disabled).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 3b378929-86b1-42a4-a112-ca4b28694de4
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/release/openshift-release-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (3)
ci-operator/config/openshift/release/openshift-release-main__nightly-4.19-upgrade-from-stable-4.18.yamlci-operator/config/openshift/release/openshift-release-main__nightly-4.20-upgrade-from-stable-4.19.yamlci-operator/config/openshift/release/openshift-release-main__nightly-4.21-upgrade-from-stable-4.20.yaml
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.21-upgrade-from-stable-4.20-opct-platform-external-aws-upgrade |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
c8def77 to
6d45532
Compare
Add opct-platform-external-aws-ccm-upgrade periodic job to the upgrade-from-stable configs for OCP 4.19, 4.20, and 4.21. These jobs exercise the OPCT upgrade conformance workflow on platform-external installations on AWS (with CCM), using the existing opct-conformance-external-aws workflow with OPCT_RUN_MODE set to upgrade. This provides baseline upgrade stability results on AWS that can be compared with the existing vSphere upgrade jobs. The upgrade path follows the openshift/release convention of upgrading from 4.Y-1 to 4.Y (initial -> latest), as defined in each upgrade-from-stable variant file.
6d45532 to
50e77bb
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.21-upgrade-from-stable-4.20-opct-platform-external-aws-upgrade |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mtulio: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
/lgtm I will wait for the rehearsal job results to check if upgrade workflow will behave as expected. /hold |
|
I got final results at job, overall it executed the job as expected and produced the report, the problem that the target version is not yet healthy due known bug affecting 4.21+, running older test versions for final review: /pj-rehearse periodic-ci-openshift-release-main-nightly-4.19-upgrade-from-stable-4.18-opct-platform-external-aws-upgrade periodic-ci-openshift-release-main-nightly-4.20-upgrade-from-stable-4.19-opct-platform-external-aws-upgrade |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Install failure, unrelated: |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mtulio: job(s): periodic-ci-openshift-release-main-nightly-4.19-upgrade-from-stable-4.18-opct-platform-external-aws- either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-4.19-upgrade-from-stable-4.18-opct-platform-external-aws-upgrade |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/hold cancel |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mtulio any reason not to get 5.0 as well? |
@neisw it will be in follow up PRs for those reasons:
|
|
/assign @neisw |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtulio, neisw, redhat-chai-bot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@redhat-chai-bot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
7d9a317
into
openshift:main
…penshift#79992) Add opct-platform-external-aws-ccm-upgrade periodic job to the upgrade-from-stable configs for OCP 4.19, 4.20, and 4.21. These jobs exercise the OPCT upgrade conformance workflow on platform-external installations on AWS (with CCM), using the existing opct-conformance-external-aws workflow with OPCT_RUN_MODE set to upgrade. This provides baseline upgrade stability results on AWS that can be compared with the existing vSphere upgrade jobs. The upgrade path follows the openshift/release convention of upgrading from 4.Y-1 to 4.Y (initial -> latest), as defined in each upgrade-from-stable variant file. Co-authored-by: Chai Bot <chai-bot@redhat.com>
…penshift#79992) Add opct-platform-external-aws-ccm-upgrade periodic job to the upgrade-from-stable configs for OCP 4.19, 4.20, and 4.21. These jobs exercise the OPCT upgrade conformance workflow on platform-external installations on AWS (with CCM), using the existing opct-conformance-external-aws workflow with OPCT_RUN_MODE set to upgrade. This provides baseline upgrade stability results on AWS that can be compared with the existing vSphere upgrade jobs. The upgrade path follows the openshift/release convention of upgrading from 4.Y-1 to 4.Y (initial -> latest), as defined in each upgrade-from-stable variant file. Co-authored-by: Chai Bot <chai-bot@redhat.com>
…penshift#79992) Add opct-platform-external-aws-ccm-upgrade periodic job to the upgrade-from-stable configs for OCP 4.19, 4.20, and 4.21. These jobs exercise the OPCT upgrade conformance workflow on platform-external installations on AWS (with CCM), using the existing opct-conformance-external-aws workflow with OPCT_RUN_MODE set to upgrade. This provides baseline upgrade stability results on AWS that can be compared with the existing vSphere upgrade jobs. The upgrade path follows the openshift/release convention of upgrading from 4.Y-1 to 4.Y (initial -> latest), as defined in each upgrade-from-stable variant file. Co-authored-by: Chai Bot <chai-bot@redhat.com>
What
Add
opct-platform-external-aws-upgradeperiodic jobs to the upgrade-from-stable configs for OCP 4.19, 4.20, 4.21, and 4.22.Why
OPCT currently has upgrade conformance periodic jobs only on vSphere. There are no upgrade jobs exercising the OPCT upgrade workflow on AWS, which is needed to:
Related Jira: OPCT-400 (Stabilize OPCT validation workflows on OCP)
How
Adds a new test entry to each of the four upgrade config files:
openshift-release-main__nightly-4.19-upgrade-from-stable-4.18.yamlopenshift-release-main__nightly-4.20-upgrade-from-stable-4.19.yamlopenshift-release-main__nightly-4.21-upgrade-from-stable-4.20.yamlopenshift-release-main__nightly-4.22-upgrade-from-stable-4.21.yamlThe new job:
opct-conformance-external-awsworkflowOPCT_RUN_MODE=upgradeandUPGRADE_TO_CHANNEL_TYPE=candidate@weeklywithcluster_profile: openshift-org-awsPLATFORM_EXTERNAL_CCM_ENABLEDis not set)#forum-opct-updatesThe prowjob YAML was regenerated using
make jobs.Generated job names
periodic-ci-openshift-release-main-nightly-4.19-upgrade-from-stable-4.18-opct-platform-external-aws-upgradeperiodic-ci-openshift-release-main-nightly-4.20-upgrade-from-stable-4.19-opct-platform-external-aws-upgradeperiodic-ci-openshift-release-main-nightly-4.21-upgrade-from-stable-4.20-opct-platform-external-aws-upgradeperiodic-ci-openshift-release-main-nightly-4.22-upgrade-from-stable-4.21-opct-platform-external-aws-upgradeReference configs
opct-external-aws-ccmin nightly configsplatform-external-vsphere-upgradein OPCT repo configs/cc @mtulio