Repository navigation
Conversation
Replace reconnect-count assertions with checks for the manager's UNRECOGNISED rejection and completion of session cleanup. Requiring six CONNECTING and CONNECTED transitions within 15 seconds depended on retry timing and whether socket closure occurred before CONNECTED was reported. Observe rejection server-side because the asynchronous disconnect message can race with socket closure and never reach the client. Wait for session cleanup before checking connector state and proceeding to the next attempt. Verify that the legitimate gateway session remains intact and that the rogue client cannot establish a gateway session or start synchronization. These checks assert the intended behavior without depending on reconnect frequency or disconnect-message delivery. Closes #1416
4 tasks
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace reconnect-count assertions with checks for the manager's UNRECOGNISED rejection and completion of session cleanup. Requiring six CONNECTING and CONNECTED transitions within 15 seconds depended on retry timing and whether socket closure occurred before CONNECTED was reported.
Observe rejection server-side because the asynchronous disconnect message can race with socket closure and never reach the client. Wait for session cleanup before checking connector state and proceeding to the next attempt.
Verify that the legitimate gateway session remains intact and that the rogue client cannot establish a gateway session or start synchronization. These checks assert the intended behavior without depending on reconnect frequency or disconnect-message delivery.
Closes #1416
Checklist